From: Mike Christie <michael.christie@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Cai Huoqing <caihuoqing@baidu.com>
Cc: Jason Wang <jasowang@redhat.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vhost: Make use of the helper macro kthread_run()
Date: Wed, 27 Oct 2021 15:12:39 -0500 [thread overview]
Message-ID: <da656ae0-eec3-88ea-9ed2-41740608c691@oracle.com> (raw)
In-Reply-To: <20211027160010-mutt-send-email-mst@kernel.org>
On 10/27/21 3:02 PM, Michael S. Tsirkin wrote:
> On Thu, Oct 21, 2021 at 04:44:06PM +0800, Cai Huoqing wrote:
>> Repalce kthread_create/wake_up_process() with kthread_run()
>> to simplify the code.
>>
>> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
>
> Pls check how this interacts with Mike Christie's patches.
> Pls fix up the typo in the commit log.
>
Hi Cai,
We probably don't need this patch since it's an API cleanup and
not fixing a bug. I'm replacing this code with the kernel_worker API
with this patch
https://lore.kernel.org/all/20211007214448.6282-9-michael.christie@oracle.com/
in this patchset;
https://lore.kernel.org/all/20211007214448.6282-1-michael.christie@oracle.com/
so the issue of using kthread_create + wake_up_process will be
gone shortly either way.
next prev parent reply other threads:[~2021-10-27 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 8:44 [PATCH] vhost: Make use of the helper macro kthread_run() Cai Huoqing
2021-10-27 20:02 ` Michael S. Tsirkin
2021-10-27 20:12 ` Mike Christie [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-27 2:08 Yin Xiujiang
2022-01-27 8:31 ` Jason Wang
2022-01-27 12:41 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da656ae0-eec3-88ea-9ed2-41740608c691@oracle.com \
--to=michael.christie@oracle.com \
--cc=caihuoqing@baidu.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).