From: Grant Grundler <grundler@google.com>
To: Brandon Philips <brandon@ifup.org>
Cc: David Miller <davem@davemloft.net>,
tobias@ringis.se, kyle@mcmartin.ca, netdev@vger.kernel.org,
grundler@parisc-linux.org
Subject: Re: dmfe/tulip device id overlap
Date: Mon, 30 Nov 2009 09:14:01 -0800 [thread overview]
Message-ID: <da824cf30911300914p2d08b87cr4625e9bc30ec7e5b@mail.gmail.com> (raw)
In-Reply-To: <20091130065512.GA2792@jenkins.domain_not_set.invalid>
On Sun, Nov 29, 2009 at 10:55 PM, Brandon Philips <brandon@ifup.org> wrote:
> Hello Dave-
>
> On 00:30 Sun 29 Nov 2009, David Miller wrote:
>> From: Grant Grundler <grundler@google.com>
>> Date: Wed, 25 Nov 2009 09:24:54 -0800
>>
>> > I'm ok with this patch except the mention of Ubuntu in the comment is
>> > superfluous. All the distro's will share this problem. I trust davem
>> > to rewrite the comment and plase add my:
>> > Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
>>
>> Please remove the comment and the __sparc__ ifdef.
>
> The comment and the __sparc__ ifdef is the entire patch... so you NACK
> the whole patch?? ;)
>
>> If tulip doesn't work on some sparc systems we simply need to fix
>> it.
>
> Tulip works on sparc as described in the linux-sparc[1] thread. The
> problem as I understand it:
>
> tulip works for the 0x9100 and 0x9102 parts that were onboard a few
> sparc motherboards.
Has anyone posted "lspci -v" output for the "Netra X1 and Sunfire
V100" motherboards?
I'm asking because I'm hoping it's possible to disambiguate the add-on
cards from
LAN-on-Motherboard cases by looking at subsystem vendor and device IDs as well.
If we are lucky, those subsystem ID to use "Sun Microsystems" Vendor IDs:
http://www.pcidatabase.com/vendor_details.php?id=526
and this will be easy to resolve.
> But, those same device IDs are used by a set of Davicom PCI cards that
> only work with the dmfe driver.
>
> Thus, the patch only lets tulip handle 0x9100 and 0x9102 if __sparc__.
>
> Perhaps someone knows if there is a way to tell the PCI card from the
> sparc builtin machine?
Do any add-on DMFE devices have OpenBOOT firmware support?
(e.g. for the Mac?) My expectation is the SPARC motherboard
devices do but that needs to be confirmed.
To be clear, I have no interest in merging dmfe driver support into
tulip driver.
I'm open to review patches that do that (and test them). Right now, I'd
only like to resolve the immediate problem SPARC users are seeing
since that seems to be pretty straight forward.
hth,
grant
>
> Cheers,
>
> Brandon
>
> [1] http://marc.info/?l=linux-sparc&m=123698696912216&w=2
>
next prev parent reply other threads:[~2009-11-30 17:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 4:36 dmfe/tulip device id overlap Brandon Philips
2009-11-25 4:49 ` Brandon Philips
2009-11-25 17:24 ` Grant Grundler
2009-11-29 8:30 ` David Miller
2009-11-30 6:55 ` Brandon Philips
2009-11-30 7:07 ` David Miller
2009-11-30 12:46 ` Ben Hutchings
2009-11-30 20:21 ` David Miller
2009-11-30 17:14 ` Grant Grundler [this message]
2009-11-30 20:26 ` David Miller
2009-11-30 22:22 ` Brandon Philips
2009-11-30 22:29 ` David Miller
2009-12-29 18:22 ` [PATCH] dmfe/tulip: Let dmfe handle DM910x except for SPARC on-board chips Ben Hutchings
2009-12-29 18:41 ` Grant Grundler
2010-01-04 5:36 ` David Miller
2009-11-25 13:08 ` dmfe/tulip device id overlap Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da824cf30911300914p2d08b87cr4625e9bc30ec7e5b@mail.gmail.com \
--to=grundler@google.com \
--cc=brandon@ifup.org \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=kyle@mcmartin.ca \
--cc=netdev@vger.kernel.org \
--cc=tobias@ringis.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).