From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBA0B318EDB; Wed, 11 Feb 2026 09:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770802729; cv=none; b=jvUWwVODi1aKaGXf+k/yeNNqVHLV4dTAMJxPROcsfj88Fpw+JmGNfWsfm6VWQc6MvRe554ZqSsIh+A6mhGojOxnclUdJczEUlPF8vmLfWl8loplf1bT//AoGdJ9wlcFyinjobtHNQ87LaRIjAZ31836jUQDpwEbL9bMAVYS6jKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770802729; c=relaxed/simple; bh=TcIXjJVAwo0wUxg9/13yDcRkD00qe4LB4KLTTW0dogM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dg3cNDgSEKeEcLwSgThXvlUf+VnxllQOBtTSeBAjGNnkW6GlJ6JXL642bNTZtUM2DEuuVf+PetHB/CqD/8xYr2tyBshcNlukmlJjwPXEykWK/K5prfuSDT+jNEU/+333KPASExXvmnhiClwxUXX/xnmxreZCs0PVranZ5D3/h9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aM9D4jor; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aM9D4jor" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 927D6C4CEF7; Wed, 11 Feb 2026 09:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770802728; bh=TcIXjJVAwo0wUxg9/13yDcRkD00qe4LB4KLTTW0dogM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aM9D4jorgDgk4mAc2LWNZ5qCkNdZ28idtUQ8lNPFEJqHD9N0hzJzS4owm2xCvDrg7 wnJs6Yp6Xc3KmpwoxddK9GndZUTJ+ZTsfun6yD6kM7aGThPoOPKDmECmPX5MWJqu3h GLb/hYZ5QUjldW37Lt8aTdjdnpqUfUfQDpbQl3tqr8GdU7bEDX29ysoNNRA9PpcNEh nYY2beeoGgXehCtqmVsCt82vKlAGUoRJZCqJuP7rdgntJ2gP1cOtDfY5xZFxN9uYZx Nu60/61mFZCs7/ph5lj+h7Hu/aMMr9nOG48HBuCic8Jpe0srMOxEU2jMWbe1VGcKmp 97WcbEh/UEN2A== Message-ID: Date: Wed, 11 Feb 2026 10:38:40 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 02/13] net: phy: phy_port: Cleanup the of-parsing logic for phy_port To: Maxime Chevallier , davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau References: <20260205092317.755906-1-maxime.chevallier@bootlin.com> <20260205092317.755906-3-maxime.chevallier@bootlin.com> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260205092317.755906-3-maxime.chevallier@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 05/02/2026 à 10:23, Maxime Chevallier a écrit : > We don't need to maintain a mediums bitfield, let's drop it and drop a > bogus check for empty mediums, as we already check it above. > > Signed-off-by: Maxime Chevallier Reviewed-by: Christophe Leroy (CS GROUP) > --- > drivers/net/phy/phy_port.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/phy/phy_port.c b/drivers/net/phy/phy_port.c > index ec93c8ca051e..a269e9ea12c4 100644 > --- a/drivers/net/phy/phy_port.c > +++ b/drivers/net/phy/phy_port.c > @@ -53,7 +53,7 @@ struct phy_port *phy_of_parse_port(struct device_node *dn) > enum ethtool_link_medium medium; > struct phy_port *port; > const char *med_str; > - u32 pairs = 0, mediums = 0; > + u32 pairs = 0; > int ret; > > ret = fwnode_property_read_string(fwnode, "media", &med_str); > @@ -85,17 +85,12 @@ struct phy_port *phy_of_parse_port(struct device_node *dn) > return ERR_PTR(-EINVAL); > } > > - mediums |= BIT(medium); > - > - if (!mediums) > - return ERR_PTR(-EINVAL); > - > port = phy_port_alloc(); > if (!port) > return ERR_PTR(-ENOMEM); > > port->pairs = pairs; > - port->mediums = mediums; > + port->mediums = BIT(medium); > > return port; > }