From: Jacob Keller <jacob.e.keller@intel.com>
To: Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
Cc: <mschmidt@redhat.com>, <dacampbe@redhat.com>, <poros@redhat.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH iwl-next 3/6] i40e: Use DECLARE_BITMAP for flags and hw_features fields in i40e_pf
Date: Fri, 20 Oct 2023 14:28:29 -0700 [thread overview]
Message-ID: <dadb40dc-3e09-470d-9eb4-8c725249aabd@intel.com> (raw)
In-Reply-To: <20231020193746.2274379-3-ivecera@redhat.com>
On 10/20/2023 12:37 PM, Ivan Vecera wrote:
> Convert flags and hw_features fields from i40e_pf from u32 to
> bitmaps and their usage to use bit access functions.
>
> Changes:
> - Convert "pf_ptr->(flags|hw_features) & FL" to "test_bit(FL, ...)"
> - Convert "pf_ptr->(flags|hw_features) |= FL" to "set_bit(FL, ...)"
> - Convert "pf_ptr->(flags|hw_features) &= ~FL" to "clear_bit(FL, ...)"
> - Rename flag field to bitno in i40e_priv_flags and adjust ethtool
> callbacks to work with flags bitmap
> - Rename flag names where '_ENABLED'->'_ENA' and '_DISABLED'->'_DIS'
> like in ice driver
I've not been a big fan of the overly-shortened names in ice, but I
agree consistency is probably better.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2023-10-20 21:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 19:37 [PATCH iwl-next 1/6] i40e: Remove unused flags Ivan Vecera
2023-10-20 19:37 ` [PATCH iwl-next 2/6] i40e: Remove _t suffix from enum type names Ivan Vecera
2023-10-20 21:24 ` Jacob Keller
2023-10-31 10:29 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-10-20 19:37 ` [PATCH iwl-next 3/6] i40e: Use DECLARE_BITMAP for flags and hw_features fields in i40e_pf Ivan Vecera
2023-10-20 21:28 ` Jacob Keller [this message]
2023-10-30 9:03 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-10-31 10:22 ` Pucha, HimasekharX Reddy
2023-10-20 19:37 ` [PATCH iwl-next 4/6] i40e: Use DECLARE_BITMAP for flags field in i40e_hw Ivan Vecera
2023-10-20 21:29 ` Jacob Keller
2023-10-31 10:26 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-10-20 19:37 ` [PATCH iwl-next 5/6] i40e: Consolidate hardware capabilities Ivan Vecera
2023-10-20 21:34 ` Jacob Keller
2023-10-31 10:19 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-10-20 19:37 ` [PATCH iwl-next 6/6] i40e: Initialize hardware capabilities at single place Ivan Vecera
2023-10-20 21:35 ` Jacob Keller
2023-10-31 9:41 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-10-20 21:19 ` [PATCH iwl-next 1/6] i40e: Remove unused flags Jacob Keller
2023-10-20 21:24 ` Jacob Keller
2023-10-31 10:28 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dadb40dc-3e09-470d-9eb4-8c725249aabd@intel.com \
--to=jacob.e.keller@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dacampbe@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).