From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7470C2D0EC for ; Fri, 27 Mar 2020 14:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADFBF206F6 for ; Fri, 27 Mar 2020 14:26:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="Xn8tPPrw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727345AbgC0O0S (ORCPT ); Fri, 27 Mar 2020 10:26:18 -0400 Received: from mail-il1-f176.google.com ([209.85.166.176]:39164 "EHLO mail-il1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbgC0O0S (ORCPT ); Fri, 27 Mar 2020 10:26:18 -0400 Received: by mail-il1-f176.google.com with SMTP id r5so8899792ilq.6 for ; Fri, 27 Mar 2020 07:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Oii4TAjFFw2Hmj832hEAobNWUE/N1jm1qkzOSIs++rA=; b=Xn8tPPrwZbmVuZnlCEKgK6ZkNuOjxusDl0QhKOGO3nmU/qhHvdrxuSipBIJjR/wERO NV6pli5A+K0v7gzUoPcbBBoRwayLR0eGxTrFYBb5bKqVElt+1BgqZbpEFQtE4MWicM+m V69KRADh29CAYJiP5hnpjcwLmVxtbB8zK3FbKtTprliL9RANBA3O9ur5wKvQx62dFAzE B9bpF/iz50+/MsQPPMeWEZIkKSs7syySBZsq1dQGKhG3s9exsKY2eIMi6hM5bFNtjcR2 txJxfV9cZZW9gT6U0rL6lZ3SVYBa7jobeY3VloqQRyAOS2E2++abQPwsPNhuerXNGzJx u4tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Oii4TAjFFw2Hmj832hEAobNWUE/N1jm1qkzOSIs++rA=; b=eH6yHLoMjaWrY8JaXoNybazqrb1hS5B+gJum4Gh1pSd0nDSM36vN5G6U3I/YxGfnBM pdopZEPXeIA9QM8T/nxTFFPxYBcyNJMGUQXJVqxG6ARqEBvvnJuoNZO6D/aBwOF2LsMC e26San9/65vmYI9wHANzrUFLzSnIi3Ve2/by9YTrZNu2X977a8wX1FXtEdS9QYqPf6l7 cGq/8u6ta+WULIMVpbGoW5CkdU7Mp7JUcN3T/wQ0NxjahXLGpMswEpMrNnWrPlct0mR3 ylXgH5k4qxNA8rpXP2UnMPmgHMFkFC/uTicrZO9XiPf2Uqa2GH78PEckHdLk37ico3XP dIKA== X-Gm-Message-State: ANhLgQ3nQuzWEHhr/BdcIkcWCwmhhCEut9EKrhUrgUfZ0rVWRB37XfIP wpY88a/WAotmPBgR7iXfZzbWwg== X-Google-Smtp-Source: ADFU+vuGCSzhcUGz0UoOTjCPF0X/6CR8eBY+wR+v1ejFXt9FuheU9eYWGFzfrX8XGUSWJnN1X+Q+hQ== X-Received: by 2002:a92:a192:: with SMTP id b18mr13974595ill.199.1585319177493; Fri, 27 Mar 2020 07:26:17 -0700 (PDT) Received: from [10.0.0.125] (23-233-27-60.cpe.pppoe.ca. [23.233.27.60]) by smtp.googlemail.com with ESMTPSA id h15sm1581013ior.20.2020.03.27.07.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2020 07:26:17 -0700 (PDT) Subject: Re: [PATCHv3 bpf-next 3/5] bpf: Don't refcount LISTEN sockets in sk_assign() To: Joe Stringer , bpf@vger.kernel.org Cc: netdev@vger.kernel.org, daniel@iogearbox.net, ast@kernel.org, eric.dumazet@gmail.com, lmb@cloudflare.com, kafai@fb.com References: <20200327042556.11560-1-joe@wand.net.nz> <20200327042556.11560-4-joe@wand.net.nz> From: Jamal Hadi Salim Message-ID: Date: Fri, 27 Mar 2020 10:26:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200327042556.11560-4-joe@wand.net.nz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020-03-27 12:25 a.m., Joe Stringer wrote: > BPF_CALL_1(bpf_sk_release, struct sock *, sk) > { > - /* Only full sockets have sk->sk_flags. */ > - if (!sk_fullsock(sk) || !sock_flag(sk, SOCK_RCU_FREE)) > + if (sk_is_refcounted(sk)) > sock_gen_put(sk); > return 0; > } Would it make sense to have both the bpf_sk_release and bpf_sk_assign() centralized so we dont replicate the functionality in tc? Reduces maintainance overhead. Thanks for working on this! cheers, jamal