From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [Patch net] ip6mr: avoid double unregister of pim6reg device Date: Fri, 21 Apr 2017 22:34:20 +0300 Message-ID: References: <1492802839-16851-1-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: andreyknvl@google.com, Linus Torvalds To: Cong Wang , netdev@vger.kernel.org Return-path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:38425 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425193AbdDUTe2 (ORCPT ); Fri, 21 Apr 2017 15:34:28 -0400 Received: by mail-wm0-f47.google.com with SMTP id r190so24843771wme.1 for ; Fri, 21 Apr 2017 12:34:27 -0700 (PDT) In-Reply-To: <1492802839-16851-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 21/04/17 22:27, Cong Wang wrote: > If we unregister the pim6reg device via default_device_exit_batch(), > we will receive a notification and ip6mr_device_event() will > unregister it again. This causes a kernel BUG at net/core/dev.c:6813. > > Like commit 7dc00c82cbb0 ("ipv4: Fix ipmr unregister device oops") > we should avoid double-unregister in netdevice notifier. > > Reported-by: Andrey Konovalov > Cc: Linus Torvalds > Signed-off-by: Cong Wang > --- > net/ipv6/ip6mr.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > Cong, Please read the full thread, I've already provided a fix which is similar. https://patchwork.ozlabs.org/patch/753531/ Thanks, Nik