From: Ying Xue <ying.xue@windriver.com>
To: Tuong Lien Tong <tuong.t.lien@dektech.com.au>, <paulmck@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<mingo@kernel.org>, <tipc-discussion@lists.sourceforge.net>,
<kernel-team@fb.com>, <torvalds@linux-foundation.org>,
<davem@davemloft.net>
Subject: Re: [tipc-discussion] [PATCH net/tipc] Replace rcu_swap_protected() with rcu_replace_pointer()
Date: Wed, 11 Dec 2019 12:42:00 +0800 [thread overview]
Message-ID: <db88d33f-8e25-8859-84ec-3372a108c759@windriver.com> (raw)
In-Reply-To: <707801d5afc6$cac68190$605384b0$@dektech.com.au>
On 12/11/19 10:00 AM, Tuong Lien Tong wrote:
>>
>> /* Move passive key if any */
>> if (key.passive) {
>> - tipc_aead_rcu_swap(rx->aead[key.passive], tmp2, &rx->lock);
>> + tmp2 = rcu_replace_pointer(rx->aead[key.passive], tmp2,
> &rx->lock);
> The 3rd parameter should be the lockdep condition checking instead of the
> spinlock's pointer i.e. "lockdep_is_held(&rx->lock)"?
> That's why I'd prefer to use the 'tipc_aead_rcu_swap ()' macro, which is
> clear & concise at least for the context here. It might be re-used later as
> well...
>
Right. The 3rd parameter of rcu_replace_pointer() should be
"lockdep_is_held(&rx->lock)" instead of "&rx->lock".
next prev parent reply other threads:[~2019-12-11 4:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 3:31 [PATCH net/tipc] Replace rcu_swap_protected() with rcu_replace_pointer() Paul E. McKenney
2019-12-10 14:36 ` Ying Xue
2019-12-10 22:38 ` Paul E. McKenney
2019-12-11 1:31 ` Ying Xue
2019-12-11 2:00 ` [tipc-discussion] " Tuong Lien Tong
2019-12-11 3:17 ` Paul E. McKenney
2019-12-11 4:35 ` Ying Xue
2019-12-11 4:42 ` Ying Xue [this message]
2019-12-11 18:46 ` Paul E. McKenney
2019-12-12 6:14 ` Ying Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db88d33f-8e25-8859-84ec-3372a108c759@windriver.com \
--to=ying.xue@windriver.com \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=torvalds@linux-foundation.org \
--cc=tuong.t.lien@dektech.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox