From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] nfc: af_nfc: Fix Spectre v1 vulnerability Date: Sat, 22 Dec 2018 17:37:35 -0600 Message-ID: References: <20181221214753.GA2799@embeddedor> <20181222.150946.778308321544627589.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: sameo@linux.intel.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20181222.150946.778308321544627589.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 12/22/18 5:09 PM, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Fri, 21 Dec 2018 15:47:53 -0600 > >> proto is indirectly controlled by user-space, hence leading to >> a potential exploitation of the Spectre variant 1 vulnerability. >> >> This issue was detected with the help of Smatch: >> >> net/nfc/af_nfc.c:42 nfc_sock_create() warn: potential spectre issue 'proto_tab' [w] (local cap) >> >> Fix this by sanitizing proto before using it to index proto_tab. >> >> Notice that given that speculation windows are large, the policy is >> to kill the speculation on the first load and not worry if it can be >> completed with a dependent load/store [1]. >> >> [1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2 >> >> Signed-off-by: Gustavo A. R. Silva > > I'll take this directly, and queued up for -stable. > Dave, I wonder if you can take this one too: https://lore.kernel.org/lkml/20181221212229.GA32635@embeddedor/ It's pretty similar to the af_nfc one. Thanks -- Gustavo