From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:44825 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932419AbeCLCKM (ORCPT ); Sun, 11 Mar 2018 22:10:12 -0400 Received: by mail-pf0-f196.google.com with SMTP id m68so563958pfm.11 for ; Sun, 11 Mar 2018 19:10:12 -0700 (PDT) Subject: Re: [PATCH net-next 3/4] selftests: forwarding: Exit with error when missing interfaces To: Ido Schimmel , netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, mlxsw@mellanox.com References: <20180311075725.15861-1-idosch@mellanox.com> <20180311075725.15861-4-idosch@mellanox.com> From: David Ahern Message-ID: Date: Sun, 11 Mar 2018 20:10:10 -0600 MIME-Version: 1.0 In-Reply-To: <20180311075725.15861-4-idosch@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/11/18 12:57 AM, Ido Schimmel wrote: > Returning 0 gives a false sense of success when the required modules did > not even manage to be initialized and register the required net devices. > > Signed-off-by: Ido Schimmel > Reviewed-by: Jiri Pirko > --- > tools/testing/selftests/net/forwarding/lib.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: David Ahern