From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] rtnetlink: invoke 'cb->done' destructor before 'cb->args' reset
Date: Thu, 1 Nov 2018 16:11:37 +0300 [thread overview]
Message-ID: <dbd48fde-3a7f-2800-4317-4eab2ecfd41d@oracle.com> (raw)
In-Reply-To: <50d88abb-bfba-6c70-af68-7bac60a0d4b1@gmail.com>
On 10/31/2018 08:35 PM, David Ahern wrote:
> On 10/31/18 10:55 AM, David Ahern wrote:
>> I think the simplest fix for 4.20 is to break the loop if ret is non-0 -
>> restore the previous behavior.
>
> that is the only recourse. It has to bail if ret is non-0. Do you want
> to send a patch with that fix?
>
I see, and inet6_dump_fib() cleanups fib6_walker if ret is zero. Will send the fix.
next prev parent reply other threads:[~2018-11-01 22:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 6:42 [PATCH net] rtnetlink: invoke 'cb->done' destructor before 'cb->args' reset Alexey Kodanev
2018-10-31 6:42 ` Alexey Kodanev
2018-10-31 16:55 ` David Ahern
2018-10-31 17:35 ` David Ahern
2018-11-01 13:11 ` Alexey Kodanev [this message]
2018-11-01 13:42 ` Alexey Kodanev
2018-11-01 21:51 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbd48fde-3a7f-2800-4317-4eab2ecfd41d@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).