From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kodanev Subject: Re: [PATCH net] rtnetlink: invoke 'cb->done' destructor before 'cb->args' reset Date: Thu, 1 Nov 2018 16:11:37 +0300 Message-ID: References: <1540968178-18894-1-git-send-email-alexey.kodanev@oracle.com> <104f12e4-866b-b986-cb9d-28c40d5c5e84@gmail.com> <50d88abb-bfba-6c70-af68-7bac60a0d4b1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: David Miller To: David Ahern , netdev@vger.kernel.org Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:55992 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727644AbeKAWEU (ORCPT ); Thu, 1 Nov 2018 18:04:20 -0400 In-Reply-To: <50d88abb-bfba-6c70-af68-7bac60a0d4b1@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/31/2018 08:35 PM, David Ahern wrote: > On 10/31/18 10:55 AM, David Ahern wrote: >> I think the simplest fix for 4.20 is to break the loop if ret is non-0 - >> restore the previous behavior. > > that is the only recourse. It has to bail if ret is non-0. Do you want > to send a patch with that fix? > I see, and inet6_dump_fib() cleanups fib6_walker if ret is zero. Will send the fix.