From: David Ahern <dsahern@gmail.com>
To: netdev@vger.kernel.org
Cc: roopa@cumulusnetworks.com
Subject: Re: [PATCH net] net/ipv4: Initialize proto and ports in flow struct
Date: Wed, 16 May 2018 12:48:07 -0600 [thread overview]
Message-ID: <dbe6cba3-370b-d1c4-90c9-8d27adf1c5cf@gmail.com> (raw)
In-Reply-To: <20180516181834.31915-1-dsahern@gmail.com>
On 5/16/18 12:18 PM, David Ahern wrote:
> @@ -347,8 +348,11 @@ static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst,
> no_addr = idev->ifa_list == NULL;
>
> fl4.flowi4_mark = IN_DEV_SRC_VMARK(idev) ? skb->mark : 0;
> -
> - trace_fib_validate_source(dev, &fl4);
Looks like I sent the net-next version; did not mean to remove that
tracepoint in net. Will send v2
> + if (!fib4_rules_early_flow_dissect(net, skb, &fl4, &flkeys)) {
> + fl4.flowi4_proto = 0;
> + fl4.fl4_sport = 0;
> + fl4.fl4_dport = 0;
> + }
>
> if (fib_lookup(net, &fl4, &res, 0))
> goto last_resort;
prev parent reply other threads:[~2018-05-16 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 18:18 [PATCH net] net/ipv4: Initialize proto and ports in flow struct David Ahern
2018-05-16 18:48 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbe6cba3-370b-d1c4-90c9-8d27adf1c5cf@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).