From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net] net/ipv4: Initialize proto and ports in flow struct
Date: Wed, 16 May 2018 12:48:07 -0600
Message-ID: <dbe6cba3-370b-d1c4-90c9-8d27adf1c5cf@gmail.com>
References: <20180516181834.31915-1-dsahern@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: roopa@cumulusnetworks.com
To: netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f66.google.com ([74.125.83.66]:38481 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750799AbeEPSsU (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 16 May 2018 14:48:20 -0400
Received: by mail-pg0-f66.google.com with SMTP id n9-v6so669592pgq.5
        for <netdev@vger.kernel.org>; Wed, 16 May 2018 11:48:19 -0700 (PDT)
In-Reply-To: <20180516181834.31915-1-dsahern@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 5/16/18 12:18 PM, David Ahern wrote:

> @@ -347,8 +348,11 @@ static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst,
>  	no_addr = idev->ifa_list == NULL;
>  
>  	fl4.flowi4_mark = IN_DEV_SRC_VMARK(idev) ? skb->mark : 0;
> -
> -	trace_fib_validate_source(dev, &fl4);

Looks like I sent the net-next version; did not mean to remove that
tracepoint in net. Will send v2


> +	if (!fib4_rules_early_flow_dissect(net, skb, &fl4, &flkeys)) {
> +		fl4.flowi4_proto = 0;
> +		fl4.fl4_sport = 0;
> +		fl4.fl4_dport = 0;
> +	}
>  
>  	if (fib_lookup(net, &fl4, &res, 0))
>  		goto last_resort;