netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Hangbin Liu <liuhangbin@gmail.com>, <netdev@vger.kernel.org>
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>
Subject: Re: [PATCH net-next 0/4] selftests: bonding: use busy/slowwait when waiting
Date: Wed, 24 Jan 2024 14:26:36 +0100	[thread overview]
Message-ID: <dc16f6c2-9fef-4a85-96b3-cc17b5a8b636@intel.com> (raw)
In-Reply-To: <20240124095814.1882509-1-liuhangbin@gmail.com>

On 1/24/24 10:58, Hangbin Liu wrote:
> There are a lot waitings in bonding tests use sleep. Let's replace them with
> busywait or slowwait(added in the first patch). This could save much test
> time. e.g.
> 
> bond-break-lacpdu-tx.sh
>    before: 0m16.346s
>    after: 0m2.424s
> 
> bond_options.sh
>    before: 9m25.299s
>    after: 5m27.439s
> 
> bond-lladdr-target.sh
>    before: 0m7.090s
>    after: 0m6.148s
> 
> bond_macvlan.sh
>    before: 0m44.999s
>    after: 0m23.468s
> 
> In total, we could save about 270 seconds.
> 
> Hangbin Liu (4):
>    selftests/net/forwarding: add slowwait functions
>    selftests: bonding: use tc filter to check if LACP was sent
>    selftests: bonding: reduce garp_test/arp_validate test time
>    selftests: bonding: use busy/slowwait instead of hard code sleep
> 
>   .../net/bonding/bond-break-lacpdu-tx.sh       | 18 +++++-----
>   .../drivers/net/bonding/bond-lladdr-target.sh | 21 +++++++++--
>   .../drivers/net/bonding/bond_macvlan.sh       |  5 ++-
>   .../drivers/net/bonding/bond_options.sh       | 22 +++++++++---
>   .../drivers/net/bonding/bond_topo_2d1c.sh     |  6 ++--
>   tools/testing/selftests/net/forwarding/lib.sh | 36 +++++++++++++++++++
>   6 files changed, 85 insertions(+), 23 deletions(-)
> 

for the series:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

      parent reply	other threads:[~2024-01-24 13:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  9:58 [PATCH net-next 0/4] selftests: bonding: use busy/slowwait when waiting Hangbin Liu
2024-01-24  9:58 ` [PATCH net-next 1/4] selftests/net/forwarding: add slowwait functions Hangbin Liu
2024-01-24 13:25   ` Przemek Kitszel
2024-01-26  9:22     ` Hangbin Liu
2024-01-26  9:53       ` Paolo Abeni
2024-01-24  9:58 ` [PATCH net-next 2/4] selftests: bonding: use tc filter to check if LACP was sent Hangbin Liu
2024-01-24  9:58 ` [PATCH net-next 3/4] selftests: bonding: reduce garp_test/arp_validate test time Hangbin Liu
2024-01-26  9:57   ` Paolo Abeni
2024-01-26 12:52     ` Hangbin Liu
2024-01-24  9:58 ` [PATCH net-next 4/4] selftests: bonding: use busy/slowwait instead of hard code sleep Hangbin Liu
2024-01-24 13:26 ` Przemek Kitszel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc16f6c2-9fef-4a85-96b3-cc17b5a8b636@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=j.vosburgh@gmail.com \
    --cc=kuba@kernel.org \
    --cc=liali@redhat.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).