From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Oliver Neukum <oneukum@suse.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] libertas: add terminating entry to fw_table
Date: Thu, 11 Jul 2019 18:54:43 +0300 [thread overview]
Message-ID: <dc2f79c8-a6fa-2d7d-df2d-dbbd5326305e@cogentembedded.com> (raw)
In-Reply-To: <20190711142744.31956-1-oneukum@suse.com>
Hello!
On 07/11/2019 05:27 PM, Oliver Neukum wrote:
> In case no firmware was found, the system would happily read
> and try to load garbage. Terminate the table properly.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Fixes: ce84bb69f50e6 ("libertas USB: convert to asynchronous firmware loading")
The Fixed: tag should precede the sign-offs, according to DaveM...
> Reported-by: syzbot+8a8f48672560c8ca59dd@syzkaller.appspotmail.com
That should be the 1st tag, I think...
> ---
> drivers/net/wireless/marvell/libertas/if_usb.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c
> index f1622f0ff8c9..b79c65547f4c 100644
> --- a/drivers/net/wireless/marvell/libertas/if_usb.c
> +++ b/drivers/net/wireless/marvell/libertas/if_usb.c
> @@ -50,7 +50,10 @@ static const struct lbs_fw_table fw_table[] = {
> { MODEL_8388, "libertas/usb8388_v5.bin", NULL },
> { MODEL_8388, "libertas/usb8388.bin", NULL },
> { MODEL_8388, "usb8388.bin", NULL },
> - { MODEL_8682, "libertas/usb8682.bin", NULL }
> + { MODEL_8682, "libertas/usb8682.bin", NULL },
> +
> + /*terminating entry - keep at end */
Why no space after /* ?
> + { MODEL_8388, NULL, NULL }
> };
>
> static const struct usb_device_id if_usb_table[] = {
MBR, Sergei
prev parent reply other threads:[~2019-07-11 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:27 [PATCH] libertas: add terminating entry to fw_table Oliver Neukum
2019-07-11 15:54 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc2f79c8-a6fa-2d7d-df2d-dbbd5326305e@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox