From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] caif_dev: use true and false for boolean values
Date: Thu, 22 Mar 2018 14:24:54 -0500 [thread overview]
Message-ID: <dc5dfef0-2895-3fa9-8fc1-878e63cea3f0@embeddedor.com> (raw)
In-Reply-To: <20180305220537.GA15924@embeddedor.com>
Hi all,
I was just wondering about the status of this patch.
Thanks!
--
Gustavo
On 03/05/2018 04:05 PM, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> net/caif/caif_dev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
> index e0adcd1..f2848d6 100644
> --- a/net/caif/caif_dev.c
> +++ b/net/caif/caif_dev.c
> @@ -139,7 +139,7 @@ static void caif_flow_cb(struct sk_buff *skb)
>
> spin_lock_bh(&caifd->flow_lock);
> send_xoff = caifd->xoff;
> - caifd->xoff = 0;
> + caifd->xoff = false;
> dtor = caifd->xoff_skb_dtor;
>
> if (WARN_ON(caifd->xoff_skb != skb))
> @@ -213,7 +213,7 @@ static int transmit(struct cflayer *layer, struct cfpkt *pkt)
> pr_debug("queue has stopped(%d) or is full (%d > %d)\n",
> netif_queue_stopped(caifd->netdev),
> qlen, high);
> - caifd->xoff = 1;
> + caifd->xoff = true;
> caifd->xoff_skb = skb;
> caifd->xoff_skb_dtor = skb->destructor;
> skb->destructor = caif_flow_cb;
> @@ -400,7 +400,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
> break;
> }
>
> - caifd->xoff = 0;
> + caifd->xoff = false;
> cfcnfg_set_phy_state(cfg, &caifd->layer, true);
> rcu_read_unlock();
>
> @@ -435,7 +435,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
> if (caifd->xoff_skb_dtor != NULL && caifd->xoff_skb != NULL)
> caifd->xoff_skb->destructor = caifd->xoff_skb_dtor;
>
> - caifd->xoff = 0;
> + caifd->xoff = false;
> caifd->xoff_skb_dtor = NULL;
> caifd->xoff_skb = NULL;
>
>
prev parent reply other threads:[~2018-03-22 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 22:05 [PATCH] caif_dev: use true and false for boolean values Gustavo A. R. Silva
2018-03-22 19:24 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc5dfef0-2895-3fa9-8fc1-878e63cea3f0@embeddedor.com \
--to=garsilva@embeddedor.com \
--cc=davem@davemloft.net \
--cc=dmitry.tarnyagin@lockless.no \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).