From mboxrd@z Thu Jan  1 00:00:00 1970
From: Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v3 net-next 3/9] net: stmmac: Add DMA related callbacks
 for XGMAC2
Date: Fri, 3 Aug 2018 11:58:55 -0700
Message-ID: <dc666664-d93e-0408-cfd7-86b271191d3e@gmail.com>
References: <cover.1533311285.git.joabreu@synopsys.com>
 <dfb48f95fffd5929e09186243445db6746e31bf5.1533311285.git.joabreu@synopsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f195.google.com ([209.85.215.195]:43835 "EHLO
        mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727532AbeHCU4a (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 3 Aug 2018 16:56:30 -0400
Received: by mail-pg1-f195.google.com with SMTP id d17-v6so3236534pgv.10
        for <netdev@vger.kernel.org>; Fri, 03 Aug 2018 11:58:58 -0700 (PDT)
In-Reply-To: <dfb48f95fffd5929e09186243445db6746e31bf5.1533311285.git.joabreu@synopsys.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 08/03/2018 08:50 AM, Jose Abreu wrote:
> Add the DMA related callbacks for the new IP block XGMAC2.
> 
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> ---

> +	value &= ~XGMAC_RD_OSR_LMT;
> +	value |= (axi->axi_rd_osr_lmt << XGMAC_RD_OSR_LMT_SHIFT) &
> +		XGMAC_RD_OSR_LMT;
> +
> +	for (i = 0; i < AXI_BLEN; i++) {
> +		if (axi->axi_blen[i])
> +			value &= ~XGMAC_UNDEF;

Should not you be you clearing all XGMAC_BLEN* values since you do a
logical or here? I am assuming this is not something that would likely
change from one open/close but still?
-- 
Florian