From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09C3CC31681 for ; Mon, 21 Jan 2019 17:40:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C93B82089F for ; Mon, 21 Jan 2019 17:40:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GnFAHvJG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbfAURkp (ORCPT ); Mon, 21 Jan 2019 12:40:45 -0500 Received: from mail-pg1-f177.google.com ([209.85.215.177]:42054 "EHLO mail-pg1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfAURkp (ORCPT ); Mon, 21 Jan 2019 12:40:45 -0500 Received: by mail-pg1-f177.google.com with SMTP id d72so9768212pga.9 for ; Mon, 21 Jan 2019 09:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uV65ZoEz1qD9RsIzwrAXL91PoPwbL6LuvpZUZ5wB1QE=; b=GnFAHvJG6rE3MhlWLKXZwYac16h9iPqRbp3ZEeyjuC6cpwJsTHrR4ffMQAVepSxmSB GUxmFmWuxSkVjFEZtpY7l+dxahirJ/gXgtISLuV0bnN/OQFxmwQR5h0NXHeyWpp76N17 2o5DrJH384VQju9PIoaOw0GZlSYyUI+Q1cPj3LSll3LEWU/9qIEX39oSNJ3areKtLKCT zGcCB5b1ebVqOAeN1q40V+hKDFQgDqhPMs2Kk1LCeWCFExWGlF4exKm7lSynL5W5F6l9 XiMboeZhf5v5rvtcXv0xMkrjMcCN7jaGVW7adERZUHfBUSwVQeX6hJ6joIN43GO0r4YD 1Nvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uV65ZoEz1qD9RsIzwrAXL91PoPwbL6LuvpZUZ5wB1QE=; b=UPc4+UxbM2wKG8lDc/9TSpOEMXQwbbXqdWSomo5skZtCfInJ6fuaYG29alDHjN0eZ9 GzEORlJDRZt0jm+j5ZL4Ooaw6zE1aLmeDIhUn8IDNgQv0yWhIn0e3rIHqVauEzdL3C5j y4irpMAesuKUVPKPYOA6F9oReU8jLe/RoqTK3Ymk6ylLxAtpj5ogRhyb5Bydg6M8owiW /rTaxYeEzv//3X5MKcNqljag9WG+DaIkZA4gIFRIpoeqF5zW2IAiDlQ743LCoB2BvAKB Ga29JC7DqJwzB9QCOaBpIM/PUrOjNaJ41D+rdCzl3zrYFH8pl6y9PyhWgGwppG3nSLGi eooQ== X-Gm-Message-State: AJcUukeh9m1NPINCz+D1vMGJpi2W+rhsUiop1/Qf31vPJ+W25agViWgz 2qfRWdqNEqXYPxd4AKsI4f7H7EYe X-Google-Smtp-Source: ALg8bN5dW9w7WNLBaIjkCEFq55Bz2v9KZ6ad5uL+c3z7OWvNZ7eYoTAGRSXVyrj1zsQHUS5h2ncVnw== X-Received: by 2002:a63:2222:: with SMTP id i34mr26848325pgi.83.1548092444505; Mon, 21 Jan 2019 09:40:44 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:d58c:9df2:49cf:9a2a? ([2601:282:800:fd80:d58c:9df2:49cf:9a2a]) by smtp.googlemail.com with ESMTPSA id b202sm20863703pfb.88.2019.01.21.09.40.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 09:40:43 -0800 (PST) Subject: Re: [PATCH v2 iproute2] ip: support for xfrm interfaces To: Matt Ellison Cc: netdev@vger.kernel.org, stephen@networkplumber.org References: <20190117094037.36ea8631@aquamarine> <5767ec25-88ac-88f9-3ea8-31a90c0659d7@gmail.com> <20190121120514.080451d1@aquamarine> From: David Ahern Message-ID: Date: Mon, 21 Jan 2019 10:40:42 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190121120514.080451d1@aquamarine> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/21/19 10:05 AM, Matt Ellison wrote: > On Mon, 21 Jan 2019 09:14:52 -0700 David Ahern wrote: > >> You always add IF_ID even if not set by user. The kernel code does not >> appear to require it so why pass a default value? > > 0 (the default) is a valid IF_ID, so setting an interface with a non-zero IF_ID > back to 0 is possible. I think the better solution would be to check for existing > values so an "ip link set" doesn't try and automatically use 0 if unsepcified. I would expect IF_ID to only be added to the request if passed on the command line. That should handle the set link case. > >> The kernel code does appear to require this parameter, so why have >> this requirement in iproute2? > > Looks to be required, without the check I get: > RTNETLINK answers: No such device > >> What about IFLA_XFRM_LINK? > > It shows up as the parent interface when you ip link show: > > 13: xfrm2@wlan0: mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 > link/none 48:e2:44:f6:77:51 brd ff:ff:ff:ff:ff:ff > > But I can print it again if you think I should. > ok, so IFLA_XFRM_LINK duplicates IFLA_LINK. no need to print twice.