From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [RFC v4 5/5] virtio_ring: enable packed ring Date: Wed, 16 May 2018 14:42:53 +0300 Message-ID: References: <20180516083737.26504-1-tiwei.bie@intel.com> <20180516083737.26504-6-tiwei.bie@intel.com> <27dfb4e8-6d63-bf7d-0f97-ac51559f8040@cogentembedded.com> <20180516102159.GA11467@debian> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, wexu@redhat.com To: Tiwei Bie Return-path: In-Reply-To: <20180516102159.GA11467@debian> Content-Language: en-MW List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 05/16/2018 01:21 PM, Tiwei Bie wrote: >>> Signed-off-by: Tiwei Bie >>> --- >>> drivers/virtio/virtio_ring.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c >>> index de3839f3621a..b158692263b0 100644 >>> --- a/drivers/virtio/virtio_ring.c >>> +++ b/drivers/virtio/virtio_ring.c >>> @@ -1940,6 +1940,8 @@ void vring_transport_features(struct virtio_device *vdev) >>> break; >>> case VIRTIO_F_IOMMU_PLATFORM: >>> break; >>> + case VIRTIO_F_RING_PACKED: >>> + break; >> >> Why not just add this *case* under the previous *case*? > > Do you mean fallthrough? Something like: > > case VIRTIO_F_IOMMU_PLATFORM: > case VIRTIO_F_RING_PACKED: > break; Yes, exactly. :-) > Best regards, > Tiwei Bie [...] MBR, Sergei