From: Daolong Wang <ahlongxp@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: bhutchings@solarflare.com, lizf@cn.fujitsu.com,
qhfeng.kernel@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NET: fix wrong English expression in comments
Date: Tue, 13 Jan 2009 14:16:02 +0800 [thread overview]
Message-ID: <dc84318c0901122216s77bae26eo2dd36c4a0ee35177@mail.gmail.com> (raw)
In-Reply-To: <20090112.215320.197154233.davem@davemloft.net>
The patch will make sense for some people. I was puzzled about the
double-negative for quite a while.
On Tue, Jan 13, 2009 at 1:53 PM, David Miller <davem@davemloft.net> wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Mon, 12 Jan 2009 01:39:18 +0000
>
>> On Mon, 2009-01-12 at 09:05 +0800, Li Zefan wrote:
>> > > @@ -103,7 +103,7 @@ struct inet_bind_bucket;
>> > > struct inet_timewait_sock {
>> > > /*
>> > > * Now struct sock also uses sock_common, so please just
>> > > - * don't add nothing before this first member (__tw_common) --acme
>> > > + * don't add anything before this first member (__tw_common) --acme
>> >
>> > They are the same meaning...
>>
>> A double-negative can be an informal way of reinforcing a negative, but
>> can sometimes mean the positive. So this change would remove a minor
>> ambiguity. However I think it should be clear that it is not compulsory
>> to add new members to the structure. ;-)
>
> After all of this discussion, I think I'm going to keep this comment
> as-is. :-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2009-01-13 6:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 18:36 [PATCH] NET: fix wrong English expression in comments Qinghuang Feng
2009-01-12 1:05 ` Li Zefan
2009-01-12 1:39 ` Ben Hutchings
2009-01-13 5:53 ` David Miller
2009-01-13 6:16 ` Daolong Wang [this message]
2009-01-13 8:41 ` David Newall
2009-01-13 9:04 ` Alan Cox
2009-01-13 12:09 ` David Newall
2009-01-13 23:22 ` Valdis.Kletnieks
2009-01-13 23:30 ` Randy Dunlap
[not found] ` <6b1ba94c0901122336r511fa316o5f520a8d2d9d6e0@mail.gmail.com>
2009-01-13 7:44 ` David Miller
2009-01-13 7:56 ` Li Zefan
2009-01-13 7:57 ` Eric Dumazet
2009-01-13 8:52 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc84318c0901122216s77bae26eo2dd36c4a0ee35177@mail.gmail.com \
--to=ahlongxp@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=qhfeng.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).