netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next 0/4] JSON (and color) support for iproute
Date: Sat, 10 Feb 2018 09:25:42 -0700	[thread overview]
Message-ID: <dc85ba6d-40b7-138e-74c7-16ee3c11e5db@gmail.com> (raw)
In-Reply-To: <20180208162625.13727-1-sthemmin@microsoft.com>

On 2/8/18 9:26 AM, Stephen Hemminger wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> 
> This set of patches adds JSON output to route printing.
> Tested for the simple cases, but there are many variations and there
> such as lw tunnels which have not be tested.
> 
> The color formatting may need some additional tweaks. It looks
> like for some tags the tag is also showing up in color.
> This should be fixed in print_color_string rather than having
> to do special case handling in so many places.
> 
> This patchset also changes the default JSON output to be compressed
> (since the purpose of JSON is to make output machine readable);
> but do optional pretty print formatting with -p flag.

Looks good. Series applied to iproute2-next.

      parent reply	other threads:[~2018-02-10 16:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08 16:26 [PATCH iproute2-next 0/4] JSON (and color) support for iproute Stephen Hemminger
2018-02-08 16:26 ` [PATCH iproute2-next 1/4] json: make pretty printing optional Stephen Hemminger
2018-02-08 16:26 ` [PATCH iproute2-next 2/4] man: add documentation for json and pretty flags Stephen Hemminger
2018-02-08 16:26 ` [PATCH iproute2-next 3/4] json: fix newline at end of array Stephen Hemminger
2018-02-08 16:26 ` [PATCH iproute2-next 4/4] iproute: implement JSON and color output Stephen Hemminger
2018-02-10 16:25 ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc85ba6d-40b7-138e-74c7-16ee3c11e5db@gmail.com \
    --to=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).