From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2-next 0/4] JSON (and color) support for iproute Date: Sat, 10 Feb 2018 09:25:42 -0700 Message-ID: References: <20180208162625.13727-1-sthemmin@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from mail-pl0-f50.google.com ([209.85.160.50]:45234 "EHLO mail-pl0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbeBJQZo (ORCPT ); Sat, 10 Feb 2018 11:25:44 -0500 Received: by mail-pl0-f50.google.com with SMTP id p5so2874239plo.12 for ; Sat, 10 Feb 2018 08:25:44 -0800 (PST) In-Reply-To: <20180208162625.13727-1-sthemmin@microsoft.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2/8/18 9:26 AM, Stephen Hemminger wrote: > From: Stephen Hemminger > > This set of patches adds JSON output to route printing. > Tested for the simple cases, but there are many variations and there > such as lw tunnels which have not be tested. > > The color formatting may need some additional tweaks. It looks > like for some tags the tag is also showing up in color. > This should be fixed in print_color_string rather than having > to do special case handling in so many places. > > This patchset also changes the default JSON output to be compressed > (since the purpose of JSON is to make output machine readable); > but do optional pretty print formatting with -p flag. Looks good. Series applied to iproute2-next.