From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA6FDC77B71 for ; Fri, 14 Apr 2023 22:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbjDNWAK (ORCPT ); Fri, 14 Apr 2023 18:00:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbjDNWAJ (ORCPT ); Fri, 14 Apr 2023 18:00:09 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99337423C; Fri, 14 Apr 2023 15:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iogearbox.net; s=default2302; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=6vEBUNhEZchpnXN5KnFTDEh5GGle3ueKXF8PZpuXJnE=; b=kN2fVE4cW9L1hHEcvdBr0MkUis zXS60VqWFcqGIQPlsnvbmrLfsrIPVbdIB89Wrm9czJzee9TZnSyyXz+Th7WOWx2jgFRgWPkZ+6p03 0eKld6TDmsl+ddsgFRo2+QpC+1stFEJtbLmj0sEh99fIzIUGULXBkbOQDy9BjdTgTOfcrI/U9zAsT p9V3wKiXeFs+Cl5JrNRXV27ImeYOYmIf3ksYZxefocmX2Tl+i5GJ7snLTxIvyH0JzjHVKiFwRcBpQ 5HMElcawviAkRHvTxZTNrj6cyCzQ6pskUNoTGKASFDUlmEZoXlhZiDF+enMjH1N0tVYJ0E6wpfTJP P5ZPVpnQ==; Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pnRSX-000F3X-Qg; Fri, 14 Apr 2023 23:59:57 +0200 Received: from [85.1.206.226] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnRSX-0001NR-Go; Fri, 14 Apr 2023 23:59:57 +0200 Subject: Re: [PATCH bpf] selftests/bpf: fix xdp_redirect xdp-features for xdp_bonding selftest To: Lorenzo Bianconi , bpf@vger.kernel.org Cc: netdev@vger.kernel.org, lorenzo.bianconi@redhat.com, ast@kernel.org, andrii@kernel.org, martin.lau@linux.dev, joamaki@gmail.com References: <73f0028461c4f3fa577e24d8d797ddd76f1d17c6.1681507058.git.lorenzo@kernel.org> From: Daniel Borkmann Message-ID: Date: Fri, 14 Apr 2023 23:59:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <73f0028461c4f3fa577e24d8d797ddd76f1d17c6.1681507058.git.lorenzo@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.8/26875/Fri Apr 14 09:23:27 2023) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/14/23 11:21 PM, Lorenzo Bianconi wrote: > NETDEV_XDP_ACT_NDO_XMIT is not enabled by default for veth driver but it > depends on the device configuration. Fix XDP_REDIRECT xdp-features in > xdp_bonding selftest loading a dummy XDP program on veth2_2 device. > > Fixes: fccca038f300 ("veth: take into account device reconfiguration for xdp_features flag") Hm, does that mean we're changing^breaking existing user behavior iff after fccca038f300 you can only make it work by loading dummy prog? > Signed-off-by: Lorenzo Bianconi > --- > tools/testing/selftests/bpf/prog_tests/xdp_bonding.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_bonding.c b/tools/testing/selftests/bpf/prog_tests/xdp_bonding.c > index 5e3a26b15ec6..dcbe30c81291 100644 > --- a/tools/testing/selftests/bpf/prog_tests/xdp_bonding.c > +++ b/tools/testing/selftests/bpf/prog_tests/xdp_bonding.c > @@ -168,6 +168,17 @@ static int bonding_setup(struct skeletons *skeletons, int mode, int xmit_policy, > > if (xdp_attach(skeletons, skeletons->xdp_dummy->progs.xdp_dummy_prog, "veth1_2")) > return -1; > + > + if (!ASSERT_OK(setns_by_name("ns_dst"), "set netns to ns_dst")) > + return -1; > + > + /* Load a dummy XDP program on veth2_2 in order to enable > + * NETDEV_XDP_ACT_NDO_XMIT feature > + */ > + if (xdp_attach(skeletons, skeletons->xdp_dummy->progs.xdp_dummy_prog, "veth2_2")) > + return -1; > + > + restore_root_netns(); > } > > SYS("ip -netns ns_dst link set veth2_1 master bond2"); >