From: Florian Fainelli <f.fainelli@gmail.com>
To: Tong Zhang <ztong0001@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] enetc: auto select PHYLIB and MDIO_DEVRES
Date: Thu, 11 Feb 2021 09:38:11 -0800 [thread overview]
Message-ID: <dcb02f4e-2fad-b44f-9bc0-098cb654b145@gmail.com> (raw)
In-Reply-To: <20210211160930.1231035-1-ztong0001@gmail.com>
On 2/11/21 8:09 AM, Tong Zhang wrote:
> FSL_ENETC_MDIO use symbols from PHYLIB and MDIO_DEVRES, however they are
> not auto selected.
>
> ERROR: modpost: "__mdiobus_register" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined!
> ERROR: modpost: "mdiobus_unregister" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined!
> ERROR: modpost: "devm_mdiobus_alloc_size" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined!
>
> auto select MDIO_DEVRES and PHYLIB when FSL_ENETC_MDIO is selected.
depends on MDIO_DEVRES && MDIO_BUS
would be more appropriate because the symbols you reference are part of
the MDIO bus layer, which happens to associated with PHYLIB depending on
the configuration but as far as build goes you can separate the two.
--
Florian
next prev parent reply other threads:[~2021-02-11 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 16:09 [PATCH] enetc: auto select PHYLIB and MDIO_DEVRES Tong Zhang
2021-02-11 17:38 ` Florian Fainelli [this message]
2021-02-11 17:54 ` [PATCH v2] " Tong Zhang
2021-02-12 2:20 ` patchwork-bot+netdevbpf
2021-02-11 17:54 ` [PATCH] " Tong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcb02f4e-2fad-b44f-9bc0-098cb654b145@gmail.com \
--to=f.fainelli@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).