From: David Ahern <dsahern@gmail.com>
To: Petr Machata <me@pmachata.org>,
netdev@vger.kernel.org, stephen@networkplumber.org,
Nikolay Aleksandrov <nikolay@nvidia.com>
Subject: Re: [PATCH iproute2-next 0/7] Convert a number of use-cases to parse_on_off(), print_on_off()
Date: Mon, 16 Nov 2020 17:56:01 -0700 [thread overview]
Message-ID: <dcbc0c8b-feb8-634c-4eec-80afa0809c06@gmail.com> (raw)
In-Reply-To: <cover.1605393324.git.me@pmachata.org>
On 11/14/20 3:53 PM, Petr Machata wrote:
> Two helpers, parse_on_off() and print_on_off(), have been recently added to
> lib/utils.c. Convert a number of instances of the same effective behavior
> to calls to these helpers.
>
> Petr Machata (7):
> bridge: link: Port over to parse_on_off()
> bridge: link: Convert to use print_on_off()
> ip: iplink: Convert to use parse_on_off()
> ip: iplink_bridge_slave: Port over to parse_on_off()
> ip: iplink_bridge_slave: Convert to use print_on_off()
> ip: ipnetconf: Convert to use print_on_off()
> ip: iptuntap: Convert to use print_on_off()
>
> bridge/link.c | 135 ++++++++++++++++++---------------------
> ip/iplink.c | 47 +++++---------
> ip/iplink_bridge_slave.c | 46 +++++--------
> ip/ipnetconf.c | 28 ++++----
> ip/iptuntap.c | 18 ++----
> 5 files changed, 112 insertions(+), 162 deletions(-)
>
looks fine to me. Added Nik for a second set of eyes on the bridge changes.
next prev parent reply other threads:[~2020-11-17 0:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 22:53 [PATCH iproute2-next 0/7] Convert a number of use-cases to parse_on_off(), print_on_off() Petr Machata
2020-11-14 22:53 ` [PATCH iproute2-next 1/7] bridge: link: Port over to parse_on_off() Petr Machata
2020-11-14 22:53 ` [PATCH iproute2-next 2/7] bridge: link: Convert to use print_on_off() Petr Machata
2020-11-14 22:53 ` [PATCH iproute2-next 3/7] ip: iplink: Convert to use parse_on_off() Petr Machata
2020-11-14 22:53 ` [PATCH iproute2-next 4/7] ip: iplink_bridge_slave: Port over to parse_on_off() Petr Machata
2020-11-14 22:53 ` [PATCH iproute2-next 5/7] ip: iplink_bridge_slave: Convert to use print_on_off() Petr Machata
2020-11-14 22:54 ` [PATCH iproute2-next 6/7] ip: ipnetconf: " Petr Machata
2020-11-14 22:54 ` [PATCH iproute2-next 7/7] ip: iptuntap: " Petr Machata
2020-11-17 0:56 ` David Ahern [this message]
2020-11-23 21:21 ` [PATCH iproute2-next 0/7] Convert a number of use-cases to parse_on_off(), print_on_off() Nikolay Aleksandrov
2020-11-25 4:44 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcbc0c8b-feb8-634c-4eec-80afa0809c06@gmail.com \
--to=dsahern@gmail.com \
--cc=me@pmachata.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).