From: Rong Chen <rong.a.chen@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Boris Pismenny <borisp@nvidia.com>,
Aviad Yehezkel <aviadye@nvidia.com>,
Vadim Fedorenko <vfedorenko@novek.ru>,
netdev@vger.kernel.org, kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH] selftests/tls: fix compile errors after adding CHACHA20-POLY1305
Date: Wed, 3 Feb 2021 09:03:41 +0800 [thread overview]
Message-ID: <dcfd45ee-46eb-618a-1e28-03e8e213df16@intel.com> (raw)
In-Reply-To: <20210202135307.6a2306fc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2/3/21 5:53 AM, Jakub Kicinski wrote:
> On Tue, 2 Feb 2021 17:45:00 +0800 Rong Chen wrote:
>> The kernel test robot reported the following errors:
>>
>> tls.c: In function ‘tls_setup’:
>> tls.c:136:27: error: storage size of ‘tls12’ isn’t known
>> union tls_crypto_context tls12;
>> ^~~~~
>> tls.c:150:21: error: ‘tls12_crypto_info_chacha20_poly1305’ undeclared (first use in this function)
>> tls12_sz = sizeof(tls12_crypto_info_chacha20_poly1305);
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> tls.c:150:21: note: each undeclared identifier is reported only once for each function it appears in
>> tls.c:153:21: error: ‘tls12_crypto_info_aes_gcm_128’ undeclared (first use in this function)
>> tls12_sz = sizeof(tls12_crypto_info_aes_gcm_128);
>>
>> Fixes: 4f336e88a870 ("selftests/tls: add CHACHA20-POLY1305 to tls selftests")
>> Reported-by: kernel test robot <oliver.sang@intel.com>
>> Link: https://lore.kernel.org/lkml/20210108064141.GB3437@xsang-OptiPlex-9020/
>> Signed-off-by: Rong Chen <rong.a.chen@intel.com>
> Are you sure you have latest headers installed on your system?
>
> Try make headers_install or some such, I forgot what the way to appease
> selftest was exactly but selftests often don't build on a fresh kernel
> clone if system headers are not very recent :S
Hi Jakub,
These errors still exist when testing the latest linux-next/master
branch on our test system,
and kernelci noticed the errors too:
https://storage.staging.kernelci.org/kernelci/staging-mainline/staging-mainline-20210130.0/x86_64/x86_64_defconfig+kselftest/gcc-8/build.log
Best Regards,
Rong Chen
next prev parent reply other threads:[~2021-02-03 1:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 9:45 [PATCH] selftests/tls: fix compile errors after adding CHACHA20-POLY1305 Rong Chen
2021-02-02 10:11 ` Vadim Fedorenko
2021-02-03 0:58 ` Rong Chen
2021-02-03 1:09 ` Vadim Fedorenko
2021-02-02 21:53 ` Jakub Kicinski
2021-02-03 1:03 ` Rong Chen [this message]
2021-02-03 1:11 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcfd45ee-46eb-618a-1e28-03e8e213df16@intel.com \
--to=rong.a.chen@intel.com \
--cc=aviadye@nvidia.com \
--cc=borisp@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).