From: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
To: netdev@vger.kernel.org
Cc: pekkas@netcore.fi, yoshfuji@linux-ipv6.org
Subject: [PATCH 1 of 5] IPv6: do not wrap around when the lifetime has expired
Date: Sun, 23 Mar 2008 21:46:09 +0100 [thread overview]
Message-ID: <dd125a7f86968371046d.1206305169@pirzuine> (raw)
In-Reply-To: <patchbomb.1206305168@pirzuine>
IPv6: do not wrap around when the lifetime has expired
Instead of reporting overly large lifetimes to userspace,
report a lifetime of 0 when a lifetime has expired.
Signed-off-by: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
diff -r c6c17f6335a1 -r dd125a7f8696 net/ipv6/addrconf.c
--- a/net/ipv6/addrconf.c Sat Mar 22 14:33:51 2008 +0100
+++ b/net/ipv6/addrconf.c Sat Mar 22 00:50:21 2008 +0100
@@ -3230,10 +3230,17 @@
preferred = ifa->prefered_lft;
valid = ifa->valid_lft;
if (preferred != INFINITY_LIFE_TIME) {
- long tval = (jiffies - ifa->tstamp)/HZ;
- preferred -= tval;
- if (valid != INFINITY_LIFE_TIME)
- valid -= tval;
+ unsigned long tval = (jiffies - ifa->tstamp)/HZ;
+ if (tval > preferred)
+ preferred = 0;
+ else
+ preferred -= tval;
+ if (valid != INFINITY_LIFE_TIME) {
+ if (tval > valid)
+ valid = 0;
+ else
+ valid -= tval;
+ }
}
} else {
preferred = INFINITY_LIFE_TIME;
next prev parent reply other threads:[~2008-03-23 20:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-23 20:46 [PATCH 0 of 5] IPv6: Fix temporary address support Benoit Boissinot
2008-03-23 20:46 ` Benoit Boissinot [this message]
2008-03-27 18:25 ` [PATCH 1 of 5] IPv6: do not wrap around when the lifetime has expired YOSHIFUJI Hideaki / 吉藤英明
2008-03-27 19:38 ` Benoit Boissinot
2008-03-28 3:06 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-01 22:43 ` Benoit Boissinot
2008-03-23 20:46 ` [PATCH 2 of 5] IPv6: only update the lifetime of the relevant temporary address Benoit Boissinot
2008-03-27 18:31 ` YOSHIFUJI Hideaki / 吉藤英明
2008-03-23 20:46 ` [PATCH 3 of 5] IPv6: do not create temporary adresses with too short preferred lifetime Benoit Boissinot
2008-03-27 18:39 ` YOSHIFUJI Hideaki / 吉藤英明
2008-03-23 20:46 ` [PATCH 4 of 5] IPv6: fix lifetime calculation on temporary address creation Benoit Boissinot
2008-03-28 3:04 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-01 21:56 ` Benoit Boissinot
2008-04-01 23:41 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-02 0:17 ` Benoit Boissinot
2008-04-02 0:25 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-02 5:56 ` Pekka Savola
2008-03-23 20:46 ` [PATCH 5 of 5] IPv6: temporary address: update the timer for tentative addresses Benoit Boissinot
2008-03-28 3:25 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-01 21:53 ` Benoit Boissinot
2008-03-27 17:59 ` [PATCH 0 of 5] IPv6: Fix temporary address support Benoit Boissinot
2008-03-27 18:12 ` YOSHIFUJI Hideaki / 吉藤英明
2008-03-28 0:32 ` Benoit Boissinot
2008-03-28 3:15 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-01 21:55 ` Benoit Boissinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd125a7f86968371046d.1206305169@pirzuine \
--to=benoit.boissinot@ens-lyon.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox