* ltp testcases failed due to commit cf3128a7aca
@ 2023-08-28 2:12 mengkanglai
2023-08-28 3:06 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: mengkanglai @ 2023-08-28 2:12 UTC (permalink / raw)
To: Steffen Klassert, Herbert Xu, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Fengtao (fengtao, Euler), Yanan (Euler)
When I run latest ltp testcase testcases/network/stress/udp/uni-basic/udp6-uni-basic07 with latest kernel 6.5, it failed in “ltpapicmd.c:188: Failed to configure SAD/SPD on the local host”.
I found that the reason for failure was this command:
output_ipsec_conf src \
$IPSEC_PROTO $IPSEC_MODE $SPI $lhost_addr $rhost_addr \
| setkey -c 2>&1 | tee $ipsec_log
This command eventually use setkey -c to add spdadd entry failed:
spdadd $src_ipaddr $dst_ipaddr any
-P out ipsec $protocol/tunnel/${src_ipaddr}-${dst_ipaddr}/use ;
It returns Invalid argument.
I found this failed due to commit cf3128a7aca(af_key: Reject optional tunnel/BEET mode templates in outbound policies), is latest ltp testcases are not adapted?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ltp testcases failed due to commit cf3128a7aca
2023-08-28 2:12 ltp testcases failed due to commit cf3128a7aca mengkanglai
@ 2023-08-28 3:06 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2023-08-28 3:06 UTC (permalink / raw)
To: mengkanglai
Cc: Steffen Klassert, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Fengtao (fengtao, Euler), Yanan (Euler)
On Mon, Aug 28, 2023 at 02:12:12AM +0000, mengkanglai wrote:
>
> This command eventually use setkey -c to add spdadd entry failed:
> spdadd $src_ipaddr $dst_ipaddr any
> -P out ipsec $protocol/tunnel/${src_ipaddr}-${dst_ipaddr}/use ;
>
> It returns Invalid argument.
>
> I found this failed due to commit cf3128a7aca(af_key: Reject optional tunnel/BEET mode templates in outbound policies), is latest ltp testcases are not adapted?
Correct. The above specification makes no sense for an outbound
policy as the SA can only be optional for inbound (where IPComp
can be skipped for incompressible plaintext). So change the word
"use" above to "require" and it should work.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-28 3:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-28 2:12 ltp testcases failed due to commit cf3128a7aca mengkanglai
2023-08-28 3:06 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).