From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FF5C169C4 for ; Thu, 31 Jan 2019 06:30:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D059D2087F for ; Thu, 31 Jan 2019 06:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729385AbfAaGaj (ORCPT ); Thu, 31 Jan 2019 01:30:39 -0500 Received: from mga12.intel.com ([192.55.52.136]:12324 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbfAaGaj (ORCPT ); Thu, 31 Jan 2019 01:30:39 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 22:30:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,543,1539673200"; d="asc'?scan'208";a="315098960" Received: from zhichaos-mobl.amr.corp.intel.com ([10.252.132.51]) by fmsmga006.fm.intel.com with ESMTP; 30 Jan 2019 22:30:38 -0800 Message-ID: Subject: Re: [ethtool 1/6] ethtool: move option parsing related code into function From: Jeff Kirsher To: "John W. Linville" , Nicholas Nunley Cc: netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com Date: Wed, 30 Jan 2019 22:30:38 -0800 In-Reply-To: <20190130210831.GD19981@tuxdriver.com> References: <20190117230313.20248-1-nicholas.d.nunley@intel.com> <20190130210831.GD19981@tuxdriver.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Qx4GnErbQqo1b+gt/8dY" User-Agent: Evolution 3.30.4 (3.30.4-1.fc29) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --=-Qx4GnErbQqo1b+gt/8dY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2019-01-30 at 16:08 -0500, John W. Linville wrote: > On Thu, Jan 17, 2019 at 03:03:08PM -0800, Nicholas Nunley wrote: > > Move option parsing code into find_option function. > >=20 > > No behavior changes. > >=20 > > Based on patch by Kan Liang > >=20 > > Signed-off-by: Nicholas Nunley >=20 > Well, after looking at this series for a while I had decided to apply it. > But when I applied it and did a 'make distcheck', I got this: >=20 > ... >=20 > gcc -DTEST_ETHTOOL -g -O2 -o test-features test_features-test- > features.o test_features-test-common.o test_features-ethtool.o > test_features-rxclass.o test_features-amd8111e.o test_features-de2104x.o > test_features-dsa.o test_features-e100.o test_features-e1000.o > test_features-et131x.o test_features-igb.o test_features-fec_8xx.o > test_features-ibm_emac.o test_features-ixgb.o test_features-ixgbe.o > test_features-natsemi.o test_features-pcnet32.o test_features-realtek.o > test_features-tg3.o test_features-marvell.o test_features-vioc.o > test_features-smsc911x.o test_features-at76c50x-usb.o test_features-sfc.o= =20 > test_features-stmmac.o test_features-sff-common.o test_features-sfpid.o > test_features-sfpdiag.o test_features-ixgbevf.o test_features-tse.o > test_features-vmxnet3.o test_features-qsfp.o test_features-fjes.o > test_features-lan78xx.o -lm=20 > make[2]: Leaving directory '/home/linville/git/ethtool/ethtool- > 4.19/_build/sub' > make check-TESTS > make[2]: Entering directory '/home/linville/git/ethtool/ethtool- > 4.19/_build/sub' > make[3]: Entering directory '/home/linville/git/ethtool/ethtool- > 4.19/_build/sub' > FAIL: test-cmdline > PASS: test-features > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D > Testsuite summary for ethtool 4.19 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D > # TOTAL: 2 > # PASS: 1 > # SKIP: 0 > # XFAIL: 0 > # FAIL: 1 > # XPASS: 0 > # ERROR: 0 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D > See ./test-suite.log > Please report to netdev@vger.kernel.org > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D > make[3]: *** [Makefile:1942: test-suite.log] Error 1 > make[3]: Leaving directory '/home/linville/git/ethtool/ethtool- > 4.19/_build/sub' > make[2]: *** [Makefile:2050: check-TESTS] Error 2 > make[2]: Leaving directory '/home/linville/git/ethtool/ethtool- > 4.19/_build/sub' > make[1]: *** [Makefile:2264: check-am] Error 2 > make[1]: Leaving directory '/home/linville/git/ethtool/ethtool- > 4.19/_build/sub' > make: *** [Makefile:2186: distcheck] Error 1 >=20 > ... >=20 > I'll attach ./ethtool-4.19/_build/sub/test-suite.log to this > message. Obviously we need whatever additional changes are needed to > get 'make check-TESTS' to pass legitimately. Interesting that we did not see this in testing. I will work with Nick to provide an updated patch, resolves your distcheck failure. --=-Qx4GnErbQqo1b+gt/8dY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlxSlg4ACgkQ5W/vlVpL 7c4xjA//cOB8Ac9UEXsBWQf4+lyuTzYie9YL+Ki9t6ZtBJjmil+pOp5wBiICYB/V 9p8Ilw+Mcnw+vu1HlBRWiqqA8WiqLKKM74xUg7RBDr1cEXGyNMzrjWwOnHxfCOUU LagAcf5Gkj/SrTjghbKylFOJno6vpwspCXRJz7x8CdTojq/6yzz2Wgytp0BUoegv QBUD8p18FsFGqUVf8QijfCTolmsONw7FsD6tlsJIhqpkkY3rWgso9qUI+dq6ZRew oiz8Wkl6SHpy5J0lL0z0y+oJD9YIKOGAKG+s3hiYDx6NU2zWXcFf7a26mA/2Vd9P iiACtkaw9YHQpC3LR40bRPgC37LoNipb/SD/fc/A/pfmWTMCa6kxdy2Zkdio2iXL glJaus9bk4lWGq7O4+QmnbsizBS2jngqMiXVCCCu9/rnaRA+SKFz9/CaTBQKaNbN w1MCEsDq0Q0Fh3gyezxFJVIgDVR3KjhGegTAaIjwT6GOUGziJ3BWvS9z2dagHysx KIB1vBUvMi25QtDZJEqYwNAjxX5KQryAu7pMCnG1LJfQ+ZQgp4O6DQR//g211plu o+6Wspt2Y5grGTa3SMth6LxS1ffe7FlMV+ZZyjs78WwvNr/ekr/AUnkPE03cDVwA uCFfRMqhQfMiOE695V7YBNxTo4Yt9mf9sSVJm1SKgSuOnVEVpyA= =TfVj -----END PGP SIGNATURE----- --=-Qx4GnErbQqo1b+gt/8dY--