From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CDECC43381 for ; Sat, 2 Mar 2019 16:16:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C91020836 for ; Sat, 2 Mar 2019 16:16:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sGT7GoMj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726614AbfCBQQT (ORCPT ); Sat, 2 Mar 2019 11:16:19 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:42557 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbfCBQQS (ORCPT ); Sat, 2 Mar 2019 11:16:18 -0500 Received: by mail-wr1-f68.google.com with SMTP id r5so982986wrg.9 for ; Sat, 02 Mar 2019 08:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=smw76F7OFHD+TQRGV4WUx/QxnW967vej2vfhCUIP04w=; b=sGT7GoMj7a0W2mrUPKEQ2CxENpB70tuw4tQ2Ov2z6+A9cMs+0E1aNKMHpboxNNMoZ7 BTAdhss4TwwUvZSnwUyb3s9Exe7HRhzYGUno+G0HtVWFOqKfB7wxhTTJNIr7Fj89kMrZ KQxIHQyTw3/gMZlpIOTNBAoSoME0kwU+lUj3iJXWutC4V+9NL/LUWVt7o2UNnrJpMbQS EhdEfMcevaAIbNurSJgjXH28FCal72/4oYGhY+phrkGOZRr0j8FQfwF0cX1HyQt1Fqp9 q4JneXYqEqJeHoAp5CN5rKgywDvB7/SAdqH4huY+jFSXvVK4fGIrIzCiqMH4HGDsgy0n 6vxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=smw76F7OFHD+TQRGV4WUx/QxnW967vej2vfhCUIP04w=; b=b49mCws79sSV2IfkIdKjF/7MHIK+S2fa7xy4wG4ArSCiszQDdrXmZo2lz9svkBHMJJ 1JVTvoPJH0ObKVOS/wMUFH/K/TNocGth7lheMWXNYEYk0vzdIwj9bHLDhbcvbp8qYkZl bVBPvAesTHys6Mk7Il+7c/gQAesp6yKXZWEgKAefbGp1JJjPNr3NgtIxAuL5DOajVoOl cBPNW4uzyKChPq1/ZUxg+gWlAwzpnImaq2Q0YKKrijwvCaCclQJJ+lxy0BaLS6ujXqkn ENzr7F++0hbulDsxnG+CBBgSwrTRGoeYsowIt/pejDCoYhA8xqj0ve96qEs5RkkPh5mh 2JYA== X-Gm-Message-State: APjAAAUa3lb2c5VqQhQU6zw5Q4wN3BDGoqfW+ka38GN93UkVsEjUN7jL gNKDyI/A9jri2Aj+/UtXO06cleu2 X-Google-Smtp-Source: APXvYqwRs+EkiUIP0UXPb/+gqdO1uPL8aV/weCfFpGahNiZyhSfnJ+lKgbzDXbePzYLR97NRPX2Haw== X-Received: by 2002:adf:b687:: with SMTP id j7mr7566890wre.81.1551543376588; Sat, 02 Mar 2019 08:16:16 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:ed04:ce8:ead3:a1ec? (p200300EA8BF1E200ED040CE8EAD3A1EC.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:ed04:ce8:ead3:a1ec]) by smtp.googlemail.com with ESMTPSA id d206sm3976061wmc.11.2019.03.02.08.16.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Mar 2019 08:16:16 -0800 (PST) Subject: [PATCH net-next 2/5] net: phy: remove gen10g_suspend and gen10g_resume From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" References: <7c0ef5fe-2f4f-d365-a028-d96179e9fab4@gmail.com> Message-ID: Date: Sat, 2 Mar 2019 17:10:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <7c0ef5fe-2f4f-d365-a028-d96179e9fab4@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org phy_suspend() and phy_resume() are no-ops anyway if no callback is defined. Therefore we don't need these stubs. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-c45.c | 14 -------------- include/linux/phy.h | 2 -- 2 files changed, 16 deletions(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 49e7cd08b..3ddbb9c32 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -529,18 +529,6 @@ int gen10g_config_init(struct phy_device *phydev) } EXPORT_SYMBOL_GPL(gen10g_config_init); -int gen10g_suspend(struct phy_device *phydev) -{ - return 0; -} -EXPORT_SYMBOL_GPL(gen10g_suspend); - -int gen10g_resume(struct phy_device *phydev) -{ - return 0; -} -EXPORT_SYMBOL_GPL(gen10g_resume); - struct phy_driver genphy_10g_driver = { .phy_id = 0xffffffff, .phy_id_mask = 0xffffffff, @@ -550,6 +538,4 @@ struct phy_driver genphy_10g_driver = { .features = PHY_10GBIT_FEATURES, .config_aneg = gen10g_config_aneg, .read_status = gen10g_read_status, - .suspend = gen10g_suspend, - .resume = gen10g_resume, }; diff --git a/include/linux/phy.h b/include/linux/phy.h index bfe60e2a5..c69de3b87 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1122,8 +1122,6 @@ int gen10g_config_aneg(struct phy_device *phydev); int gen10g_read_status(struct phy_device *phydev); int gen10g_no_soft_reset(struct phy_device *phydev); int gen10g_config_init(struct phy_device *phydev); -int gen10g_suspend(struct phy_device *phydev); -int gen10g_resume(struct phy_device *phydev); static inline int phy_read_status(struct phy_device *phydev) { -- 2.21.0