From: Florian Fainelli <f.fainelli@gmail.com>
To: Lukasz Majewski <lukma@denx.de>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: Re: [PATCH v8 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch
Date: Tue, 30 May 2023 14:38:47 -0700 [thread overview]
Message-ID: <dd68b82b-7bb7-3f4f-7243-e3a4b745cd97@gmail.com> (raw)
In-Reply-To: <20230530083916.2139667-3-lukma@denx.de>
On 5/30/23 01:39, Lukasz Majewski wrote:
> From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
>
> A mv88e6250 family switch with 2 PHY and RMII ports and
> no PTP support.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
[snip]
> /* List of supported models */
> enum mv88e6xxx_model {
> + MV88E6020,
> MV88E6085,
> MV88E6095,
> MV88E6097,
> @@ -94,7 +95,7 @@ enum mv88e6xxx_family {
> MV88E6XXX_FAMILY_6097, /* 6046 6085 6096 6097 */
> MV88E6XXX_FAMILY_6165, /* 6123 6161 6165 */
> MV88E6XXX_FAMILY_6185, /* 6108 6121 6122 6131 6152 6155 6182 6185 */
> - MV88E6XXX_FAMILY_6250, /* 6220 6250 */
> + MV88E6XXX_FAMILY_6250, /* 6220 6250 6020 */
über nit: only if you have to resubmit, numbers in ascending order.
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-05-30 21:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 8:39 [PATCH v8 0/3] dsa: marvell: Add support for mv88e6071 and 6020 switches Lukasz Majewski
2023-05-30 8:39 ` [PATCH v8 1/3] net: dsa: Define .set_max_frame_size() callback for mv88e6250 SoC family Lukasz Majewski
2023-05-30 21:36 ` Florian Fainelli
2023-05-30 8:39 ` [PATCH v8 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch Lukasz Majewski
2023-05-30 21:38 ` Florian Fainelli [this message]
2023-05-31 8:08 ` Lukasz Majewski
2023-05-30 8:39 ` [PATCH v8 3/3] net: dsa: mv88e6xxx: add support for MV88E6071 switch Lukasz Majewski
2023-05-30 21:39 ` Florian Fainelli
2023-05-31 9:10 ` [PATCH v8 0/3] dsa: marvell: Add support for mv88e6071 and 6020 switches patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd68b82b-7bb7-3f4f-7243-e3a4b745cd97@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukma@denx.de \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).