From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Alan Brady <alan.brady@intel.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
<intel-wired-lan@lists.osuosl.org>,
"Emil Tantilov" <emil.s.tantilov@intel.com>,
<netdev@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH 1/1 iwl-net] idpf: disable local BH when scheduling napi for marker packets
Date: Wed, 14 Feb 2024 15:54:31 +0100 [thread overview]
Message-ID: <dd7247e8-8a1a-4033-9c1e-c52339426b34@intel.com> (raw)
In-Reply-To: <2e3001f8-a079-4d44-863f-979baca3b38c@intel.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Tue, 13 Feb 2024 14:16:47 +0100
> From: Alan Brady <alan.brady@intel.com>
> Date: Wed, 7 Feb 2024 16:42:43 -0800
>
>> From: Emil Tantilov <emil.s.tantilov@intel.com>
>>
>> Fix softirq's not being handled during napi_schedule() call when
>> receiving marker packets for queue disable by disabling local bottom
>> half.
>
> BTW, how exactly does this help?
>
> __napi_schedule() already disables interrupts (local_irq_save()).
> napi_schedule_prep() only has READ_ONCE() and other atomic read/write
> helpers.
>
> It's always been safe to call napi_schedule() with enabled BH, so I
> don't really understand how this works.
This also needs to be dropped from the fixes queue until investigated.
For now, it looks like a cheap hack (without the explanation how exactly
it does help), not a proper fix.
Thanks,
Olek
next prev parent reply other threads:[~2024-02-14 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 0:42 [PATCH 1/1 iwl-net] idpf: disable local BH when scheduling napi for marker packets Alan Brady
2024-02-09 10:34 ` Simon Horman
2024-02-12 14:41 ` [Intel-wired-lan] " Alexander Lobakin
2024-02-12 17:43 ` Tantilov, Emil S
2024-02-13 13:16 ` Alexander Lobakin
2024-02-14 14:54 ` Alexander Lobakin [this message]
2024-02-14 15:39 ` Tantilov, Emil S
2024-02-15 13:28 ` Alexander Lobakin
2024-02-15 0:36 ` Jakub Kicinski
2024-03-05 0:44 ` Singh, Krishneil K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd7247e8-8a1a-4033-9c1e-c52339426b34@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=alan.brady@intel.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).