From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41ABFC43381 for ; Sat, 2 Mar 2019 20:34:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01738206B6 for ; Sat, 2 Mar 2019 20:34:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LCjKROod" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726601AbfCBUeX (ORCPT ); Sat, 2 Mar 2019 15:34:23 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43790 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbfCBUeW (ORCPT ); Sat, 2 Mar 2019 15:34:22 -0500 Received: by mail-wr1-f65.google.com with SMTP id d17so1370375wre.10 for ; Sat, 02 Mar 2019 12:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OOHbvHfWfvo7ReeR+hD0D9aLabgXqhRR3AxSn+AzoiE=; b=LCjKROod22CXXZ92EXk2BaYWuRRR7FaMuuPk0ykBxhb18MomGPDq6R9jRaTmbMNO8h a+fiCHiAYuA3JFqpRzwHxT24SBr6uTeI+6OSBfjhZzBZ+xXn3eLWJn97c4TGBVq7qyTi 2aV9yBxxuRqfIKN3PzYdod9XWLSvNxf1NDyZSLdU0xrW8xs4TDjub2TAXw+eojZtFkhu rKoZKxstiZffEaWQFhXTwGIQixzcUbAV0rkVkFRkNBnqyW66LGQy1PEFP4fex0i+1Gk3 r0/mv/TkRanhoGz1YbzvRqH98IBYrPhmTSIkI3rh4H8UwZY4hfe7876Nbulc396hC4tx qGTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OOHbvHfWfvo7ReeR+hD0D9aLabgXqhRR3AxSn+AzoiE=; b=uHiooQKpkbMNg3M2oJDIJTJc3K+VDoHQku4uApmSk/FiJ0M776Vi/AepFCmQb8Y+Dk MQjI/CUk94BdXH2fiEINYby/OtZSpl2fNpBbo5K3YtAtL1MoK8H8Yz3DUkv+BMHaCX+t woNFDWia/c/efpMiboW7xOSM7E9nEvm5LNJIRa3FrN24vpwlX7x5RsdeIp6R4Xxqkpie 0j2ZsylXKJXdqEEMVtvfo/MDlsdIrSC5uDNY7YGAnxo7JAw3OvtDgrWC14nWEMDF6ezV rmY7GOGlt70WQWZvtiAymiWET8zYjjW1wdgglrAXn85d5N/3PQZOb+t33hLjHypSEnxS HJvw== X-Gm-Message-State: APjAAAX40ovn6ZR0Tkxl7nDZzh9En0KfncKiDANjgJnXP9BcTPRBmW76 QGQOl+Njp6WhEqFYO8M6U4WxQHHl X-Google-Smtp-Source: APXvYqzeRS1/eFvYKtegv2YWu3aTZb5E4ZuXzstMUb++y6eStE4COvBKEjLgcliq/roiOerTouMnpw== X-Received: by 2002:a5d:6112:: with SMTP id v18mr7459612wrt.207.1551558860675; Sat, 02 Mar 2019 12:34:20 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:ed04:ce8:ead3:a1ec? (p200300EA8BF1E200ED040CE8EAD3A1EC.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:ed04:ce8:ead3:a1ec]) by smtp.googlemail.com with ESMTPSA id s5sm6487519wra.77.2019.03.02.12.34.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Mar 2019 12:34:19 -0800 (PST) Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: support in-band signalling with external PHY for 1000BaseX/2500BaseX To: Andrew Lunn Cc: Vivien Didelot , Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <20190302201307.GA10359@lunn.ch> From: Heiner Kallweit Message-ID: Date: Sat, 2 Mar 2019 21:34:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190302201307.GA10359@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02.03.2019 21:13, Andrew Lunn wrote: > On Sat, Mar 02, 2019 at 04:57:32PM +0100, Heiner Kallweit wrote: >> Propagate the external PHY settings also in 1000BaseX and >> 2500BaseX mode. > > Hi Heiner > Hi Andrew > I don't think this is needed. 1000BaseX and 2500BaseX does not support > inband signalling. So the mac_config() call for these modes should > include the needed speed configuration. I've used 1000BaseX with an > SFP and there was no need to configure anything. > 1000BaseX and 2500BaseX use 802.3z Clause 37 inband auto-neg. From what I've read 1000BaseT is an extension of it. My understanding is that w/o such inband signalling we had no chance to detect a "link up" situation. All we could detect is: serial connection is synced. Also my understanding is that the ACK to this inband signalling triggers the "link up" interrupt. Here I found something: http://www.methode.com/Documents/TechnicalLibrary/SFP_Ethernet_Auto_Negotiation.pdf I briefly looked at the SFP connector and there don't seem to be pins for out-of-band signalling. So there must be some inband signalling. > Andrew > Heiner