From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"David S . Miller" <davem@davemloft.net>
Cc: "Xo Wang" <xow@google.com>, "Joel Stanley" <joel@jms.id.au>,
"Jon Mason" <jon.mason@broadcom.com>,
"Jaedon Shin" <jaedon.shin@gmail.com>,
netdev@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] net: phy: broadcom: rehook BCM54612E specific init
Date: Tue, 31 Jan 2017 14:14:05 -0800 [thread overview]
Message-ID: <dd85a0f9-1e32-b464-fe8b-b2980e652376@gmail.com> (raw)
In-Reply-To: <20170131215454.7932-1-zajec5@gmail.com>
On 01/31/2017 01:54 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This extra BCM54612E code in PHY driver isn't really aneg specific. Even
> without it aneg works OK but the problem is no packets pass through PHY.
>
> Moreover putting this code inside config_aneg callback didn't allow
> resuming PHY correctly. When driver called phy_stop and phy_start it was
> putting PHY machine into RESUMING state. After that machine was
> switching into AN and NOLINK without ever calling phy_start_aneg. This
> prevented this extra setup from being called and PHY didn't work.
>
> This change has been verified to fix network on BCM47186B0 SoC device
> with BCM54612E.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-01-31 22:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 21:54 [PATCH] net: phy: broadcom: rehook BCM54612E specific init Rafał Miłecki
2017-01-31 22:14 ` Florian Fainelli [this message]
2017-02-01 19:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd85a0f9-1e32-b464-fe8b-b2980e652376@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=jaedon.shin@gmail.com \
--cc=joel@jms.id.au \
--cc=jon.mason@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=xow@google.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).