* [PATCH iproute2-next 1/3] vti/vti6: Unify local/remote endpoint address parsing
2018-02-09 18:06 [PATCH iproute2-next 0/3] ip/tunnel: Unify local/remote endpoint address parsing Serhey Popovych
@ 2018-02-09 18:06 ` Serhey Popovych
2018-02-09 18:06 ` [PATCH iproute2-next 2/3] gre/gre6: " Serhey Popovych
2018-02-09 18:06 ` [PATCH iproute2-next 3/3] iptnl/ip6tnl: Unify local/remote endpoint and 6rd " Serhey Popovych
2 siblings, 0 replies; 5+ messages in thread
From: Serhey Popovych @ 2018-02-09 18:06 UTC (permalink / raw)
To: netdev
We are going to merge link_vti.c and link_vti6.c and this is final step
to make their diffs clear and show what needs to be changed during merge.
Note that it is safe to omit endpoint address(es) from netlink create
request as kernel is aware of such case and will use zero for that
endpoint(s).
Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
---
ip/link_vti.c | 31 +++++++++++++++++++------------
ip/link_vti6.c | 37 +++++++++++++++++++------------------
2 files changed, 38 insertions(+), 30 deletions(-)
diff --git a/ip/link_vti.c b/ip/link_vti.c
index edd17fe..d96ba02 100644
--- a/ip/link_vti.c
+++ b/ip/link_vti.c
@@ -64,13 +64,16 @@ static int vti_parse_opt(struct link_util *lu, int argc, char **argv,
struct rtattr *vtiinfo[IFLA_VTI_MAX + 1];
__be32 ikey = 0;
__be32 okey = 0;
- unsigned int saddr = 0;
- unsigned int daddr = 0;
+ inet_prefix saddr, daddr;
unsigned int link = 0;
__u32 fwmark = 0;
int len;
+ saddr.flags = daddr.flags = 0;
+
if (!(n->nlmsg_flags & NLM_F_CREATE)) {
+ const struct rtattr *rta;
+
if (rtnl_talk(&rth, &req.n, &answer) < 0) {
get_failed:
fprintf(stderr,
@@ -96,18 +99,20 @@ get_failed:
parse_rtattr_nested(vtiinfo, IFLA_VTI_MAX,
linkinfo[IFLA_INFO_DATA]);
+ rta = vtiinfo[IFLA_VTI_LOCAL];
+ if (rta && get_addr_rta(&saddr, rta, AF_INET))
+ goto get_failed;
+
+ rta = vtiinfo[IFLA_VTI_REMOTE];
+ if (rta && get_addr_rta(&daddr, rta, AF_INET))
+ goto get_failed;
+
if (vtiinfo[IFLA_VTI_IKEY])
ikey = rta_getattr_u32(vtiinfo[IFLA_VTI_IKEY]);
if (vtiinfo[IFLA_VTI_OKEY])
okey = rta_getattr_u32(vtiinfo[IFLA_VTI_OKEY]);
- if (vtiinfo[IFLA_VTI_LOCAL])
- saddr = rta_getattr_u32(vtiinfo[IFLA_VTI_LOCAL]);
-
- if (vtiinfo[IFLA_VTI_REMOTE])
- daddr = rta_getattr_u32(vtiinfo[IFLA_VTI_REMOTE]);
-
if (vtiinfo[IFLA_VTI_LINK])
link = rta_getattr_u8(vtiinfo[IFLA_VTI_LINK]);
@@ -129,10 +134,10 @@ get_failed:
okey = tnl_parse_key("okey", *argv);
} else if (!matches(*argv, "remote")) {
NEXT_ARG();
- daddr = get_addr32(*argv);
+ get_addr(&daddr, *argv, AF_INET);
} else if (!matches(*argv, "local")) {
NEXT_ARG();
- saddr = get_addr32(*argv);
+ get_addr(&saddr, *argv, AF_INET);
} else if (!matches(*argv, "dev")) {
NEXT_ARG();
link = ll_name_to_index(*argv);
@@ -154,8 +159,10 @@ get_failed:
addattr32(n, 1024, IFLA_VTI_IKEY, ikey);
addattr32(n, 1024, IFLA_VTI_OKEY, okey);
- addattr_l(n, 1024, IFLA_VTI_LOCAL, &saddr, 4);
- addattr_l(n, 1024, IFLA_VTI_REMOTE, &daddr, 4);
+ if (is_addrtype_inet(&saddr))
+ addattr_l(n, 1024, IFLA_VTI_LOCAL, saddr.data, saddr.bytelen);
+ if (is_addrtype_inet(&daddr))
+ addattr_l(n, 1024, IFLA_VTI_REMOTE, daddr.data, daddr.bytelen);
addattr32(n, 1024, IFLA_VTI_FWMARK, fwmark);
if (link)
addattr32(n, 1024, IFLA_VTI_LINK, link);
diff --git a/ip/link_vti6.c b/ip/link_vti6.c
index 1276ebd..4dabbbb 100644
--- a/ip/link_vti6.c
+++ b/ip/link_vti6.c
@@ -64,15 +64,18 @@ static int vti6_parse_opt(struct link_util *lu, int argc, char **argv,
struct rtattr *tb[IFLA_MAX + 1];
struct rtattr *linkinfo[IFLA_INFO_MAX+1];
struct rtattr *vtiinfo[IFLA_VTI_MAX + 1];
- struct in6_addr saddr = IN6ADDR_ANY_INIT;
- struct in6_addr daddr = IN6ADDR_ANY_INIT;
__be32 ikey = 0;
__be32 okey = 0;
+ inet_prefix saddr, daddr;
unsigned int link = 0;
__u32 fwmark = 0;
int len;
+ saddr.flags = daddr.flags = 0;
+
if (!(n->nlmsg_flags & NLM_F_CREATE)) {
+ const struct rtattr *rta;
+
if (rtnl_talk(&rth, &req.n, &answer) < 0) {
get_failed:
fprintf(stderr,
@@ -98,18 +101,20 @@ get_failed:
parse_rtattr_nested(vtiinfo, IFLA_VTI_MAX,
linkinfo[IFLA_INFO_DATA]);
+ rta = vtiinfo[IFLA_VTI_LOCAL];
+ if (rta && get_addr_rta(&saddr, rta, AF_INET6))
+ goto get_failed;
+
+ rta = vtiinfo[IFLA_VTI_REMOTE];
+ if (rta && get_addr_rta(&daddr, rta, AF_INET6))
+ goto get_failed;
+
if (vtiinfo[IFLA_VTI_IKEY])
ikey = rta_getattr_u32(vtiinfo[IFLA_VTI_IKEY]);
if (vtiinfo[IFLA_VTI_OKEY])
okey = rta_getattr_u32(vtiinfo[IFLA_VTI_OKEY]);
- if (vtiinfo[IFLA_VTI_LOCAL])
- memcpy(&saddr, RTA_DATA(vtiinfo[IFLA_VTI_LOCAL]), sizeof(saddr));
-
- if (vtiinfo[IFLA_VTI_REMOTE])
- memcpy(&daddr, RTA_DATA(vtiinfo[IFLA_VTI_REMOTE]), sizeof(daddr));
-
if (vtiinfo[IFLA_VTI_LINK])
link = rta_getattr_u8(vtiinfo[IFLA_VTI_LINK]);
@@ -130,17 +135,11 @@ get_failed:
NEXT_ARG();
okey = tnl_parse_key("okey", *argv);
} else if (!matches(*argv, "remote")) {
- inet_prefix addr;
-
NEXT_ARG();
- get_addr(&addr, *argv, AF_INET6);
- memcpy(&daddr, addr.data, sizeof(daddr));
+ get_addr(&daddr, *argv, AF_INET6);
} else if (!matches(*argv, "local")) {
- inet_prefix addr;
-
NEXT_ARG();
- get_addr(&addr, *argv, AF_INET6);
- memcpy(&saddr, addr.data, sizeof(saddr));
+ get_addr(&saddr, *argv, AF_INET6);
} else if (!matches(*argv, "dev")) {
NEXT_ARG();
link = ll_name_to_index(*argv);
@@ -162,8 +161,10 @@ get_failed:
addattr32(n, 1024, IFLA_VTI_IKEY, ikey);
addattr32(n, 1024, IFLA_VTI_OKEY, okey);
- addattr_l(n, 1024, IFLA_VTI_LOCAL, &saddr, sizeof(saddr));
- addattr_l(n, 1024, IFLA_VTI_REMOTE, &daddr, sizeof(daddr));
+ if (is_addrtype_inet(&saddr))
+ addattr_l(n, 1024, IFLA_VTI_LOCAL, saddr.data, saddr.bytelen);
+ if (is_addrtype_inet(&daddr))
+ addattr_l(n, 1024, IFLA_VTI_REMOTE, daddr.data, daddr.bytelen);
addattr32(n, 1024, IFLA_VTI_FWMARK, fwmark);
if (link)
addattr32(n, 1024, IFLA_VTI_LINK, link);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH iproute2-next 2/3] gre/gre6: Unify local/remote endpoint address parsing
2018-02-09 18:06 [PATCH iproute2-next 0/3] ip/tunnel: Unify local/remote endpoint address parsing Serhey Popovych
2018-02-09 18:06 ` [PATCH iproute2-next 1/3] vti/vti6: " Serhey Popovych
@ 2018-02-09 18:06 ` Serhey Popovych
2018-02-09 18:06 ` [PATCH iproute2-next 3/3] iptnl/ip6tnl: Unify local/remote endpoint and 6rd " Serhey Popovych
2 siblings, 0 replies; 5+ messages in thread
From: Serhey Popovych @ 2018-02-09 18:06 UTC (permalink / raw)
To: netdev
We are going to merge link_gre.c and link_gre6.c and this is final step
to make their diffs clear and show what needs to be changed during merge.
Note that it is safe to omit endpoint address(es) from netlink create
request as kernel is aware of such case and will use zero for that
endpoint(s).
Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
---
ip/link_gre.c | 56 +++++++++++++++++++++++++++++++++-----------------------
ip/link_gre6.c | 37 +++++++++++++++++++------------------
2 files changed, 52 insertions(+), 41 deletions(-)
diff --git a/ip/link_gre.c b/ip/link_gre.c
index e3e5323..4f81696 100644
--- a/ip/link_gre.c
+++ b/ip/link_gre.c
@@ -86,8 +86,7 @@ static int gre_parse_opt(struct link_util *lu, int argc, char **argv,
__u16 oflags = 0;
__be32 ikey = 0;
__be32 okey = 0;
- unsigned int saddr = 0;
- unsigned int daddr = 0;
+ inet_prefix saddr, daddr;
__u8 pmtudisc = 1;
__u8 ignore_df = 0;
__u8 tos = 0;
@@ -104,7 +103,11 @@ static int gre_parse_opt(struct link_util *lu, int argc, char **argv,
__u8 erspan_dir = 0;
__u16 erspan_hwid = 0;
+ saddr.flags = daddr.flags = 0;
+
if (!(n->nlmsg_flags & NLM_F_CREATE)) {
+ const struct rtattr *rta;
+
if (rtnl_talk(&rth, &req.n, &answer) < 0) {
get_failed:
fprintf(stderr,
@@ -130,6 +133,14 @@ get_failed:
parse_rtattr_nested(greinfo, IFLA_GRE_MAX,
linkinfo[IFLA_INFO_DATA]);
+ rta = greinfo[IFLA_GRE_LOCAL];
+ if (rta && get_addr_rta(&saddr, rta, AF_INET))
+ goto get_failed;
+
+ rta = greinfo[IFLA_GRE_REMOTE];
+ if (rta && get_addr_rta(&daddr, rta, AF_INET))
+ goto get_failed;
+
if (greinfo[IFLA_GRE_IKEY])
ikey = rta_getattr_u32(greinfo[IFLA_GRE_IKEY]);
@@ -142,12 +153,6 @@ get_failed:
if (greinfo[IFLA_GRE_OFLAGS])
oflags = rta_getattr_u16(greinfo[IFLA_GRE_OFLAGS]);
- if (greinfo[IFLA_GRE_LOCAL])
- saddr = rta_getattr_u32(greinfo[IFLA_GRE_LOCAL]);
-
- if (greinfo[IFLA_GRE_REMOTE])
- daddr = rta_getattr_u32(greinfo[IFLA_GRE_REMOTE]);
-
if (greinfo[IFLA_GRE_PMTUDISC])
pmtudisc = rta_getattr_u8(
greinfo[IFLA_GRE_PMTUDISC]);
@@ -232,10 +237,10 @@ get_failed:
pmtudisc = 1;
} else if (!matches(*argv, "remote")) {
NEXT_ARG();
- daddr = get_addr32(*argv);
+ get_addr(&daddr, *argv, AF_INET);
} else if (!matches(*argv, "local")) {
NEXT_ARG();
- saddr = get_addr32(*argv);
+ get_addr(&saddr, *argv, AF_INET);
} else if (!matches(*argv, "dev")) {
NEXT_ARG();
link = ll_name_to_index(*argv);
@@ -343,17 +348,20 @@ get_failed:
argc--; argv++;
}
- if (!ikey && IN_MULTICAST(ntohl(daddr))) {
- ikey = daddr;
- iflags |= GRE_KEY;
- }
- if (!okey && IN_MULTICAST(ntohl(daddr))) {
- okey = daddr;
- oflags |= GRE_KEY;
- }
- if (IN_MULTICAST(ntohl(daddr)) && !saddr) {
- fprintf(stderr, "A broadcast tunnel requires a source address.\n");
- return -1;
+ if (is_addrtype_inet_multi(&daddr)) {
+ if (!ikey) {
+ ikey = daddr.data[0];
+ iflags |= GRE_KEY;
+ }
+ if (!okey) {
+ okey = daddr.data[0];
+ oflags |= GRE_KEY;
+ }
+ if (!is_addrtype_inet_not_unspec(&saddr)) {
+ fprintf(stderr,
+ "A broadcast tunnel requires a source address.\n");
+ return -1;
+ }
}
if (metadata) {
@@ -365,8 +373,10 @@ get_failed:
addattr32(n, 1024, IFLA_GRE_OKEY, okey);
addattr_l(n, 1024, IFLA_GRE_IFLAGS, &iflags, 2);
addattr_l(n, 1024, IFLA_GRE_OFLAGS, &oflags, 2);
- addattr_l(n, 1024, IFLA_GRE_LOCAL, &saddr, 4);
- addattr_l(n, 1024, IFLA_GRE_REMOTE, &daddr, 4);
+ if (is_addrtype_inet(&saddr))
+ addattr_l(n, 1024, IFLA_GRE_LOCAL, saddr.data, saddr.bytelen);
+ if (is_addrtype_inet(&daddr))
+ addattr_l(n, 1024, IFLA_GRE_REMOTE, daddr.data, daddr.bytelen);
addattr_l(n, 1024, IFLA_GRE_PMTUDISC, &pmtudisc, 1);
if (ignore_df)
addattr8(n, 1024, IFLA_GRE_IGNORE_DF, ignore_df & 1);
diff --git a/ip/link_gre6.c b/ip/link_gre6.c
index 251ae0e..5e68fff 100644
--- a/ip/link_gre6.c
+++ b/ip/link_gre6.c
@@ -97,8 +97,7 @@ static int gre_parse_opt(struct link_util *lu, int argc, char **argv,
__u16 oflags = 0;
__be32 ikey = 0;
__be32 okey = 0;
- struct in6_addr raddr = IN6ADDR_ANY_INIT;
- struct in6_addr laddr = IN6ADDR_ANY_INIT;
+ inet_prefix saddr, daddr;
__u8 hop_limit = DEFAULT_TNL_HOP_LIMIT;
__u8 encap_limit = IPV6_DEFAULT_TNL_ENCAP_LIMIT;
__u32 flowinfo = 0;
@@ -115,7 +114,11 @@ static int gre_parse_opt(struct link_util *lu, int argc, char **argv,
__u8 erspan_dir = 0;
__u16 erspan_hwid = 0;
+ saddr.flags = daddr.flags = 0;
+
if (!(n->nlmsg_flags & NLM_F_CREATE)) {
+ const struct rtattr *rta;
+
if (rtnl_talk(&rth, &req.n, &answer) < 0) {
get_failed:
fprintf(stderr,
@@ -141,6 +144,14 @@ get_failed:
parse_rtattr_nested(greinfo, IFLA_GRE_MAX,
linkinfo[IFLA_INFO_DATA]);
+ rta = greinfo[IFLA_GRE_LOCAL];
+ if (rta && get_addr_rta(&saddr, rta, AF_INET6))
+ goto get_failed;
+
+ rta = greinfo[IFLA_GRE_REMOTE];
+ if (rta && get_addr_rta(&daddr, rta, AF_INET6))
+ goto get_failed;
+
if (greinfo[IFLA_GRE_IKEY])
ikey = rta_getattr_u32(greinfo[IFLA_GRE_IKEY]);
@@ -153,12 +164,6 @@ get_failed:
if (greinfo[IFLA_GRE_OFLAGS])
oflags = rta_getattr_u16(greinfo[IFLA_GRE_OFLAGS]);
- if (greinfo[IFLA_GRE_LOCAL])
- memcpy(&laddr, RTA_DATA(greinfo[IFLA_GRE_LOCAL]), sizeof(laddr));
-
- if (greinfo[IFLA_GRE_REMOTE])
- memcpy(&raddr, RTA_DATA(greinfo[IFLA_GRE_REMOTE]), sizeof(raddr));
-
if (greinfo[IFLA_GRE_TTL])
hop_limit = rta_getattr_u8(greinfo[IFLA_GRE_TTL]);
@@ -236,17 +241,11 @@ get_failed:
} else if (!matches(*argv, "ocsum")) {
oflags |= GRE_CSUM;
} else if (!matches(*argv, "remote")) {
- inet_prefix addr;
-
NEXT_ARG();
- get_addr(&addr, *argv, AF_INET6);
- memcpy(&raddr, &addr.data, sizeof(raddr));
+ get_addr(&daddr, *argv, AF_INET6);
} else if (!matches(*argv, "local")) {
- inet_prefix addr;
-
NEXT_ARG();
- get_addr(&addr, *argv, AF_INET6);
- memcpy(&laddr, &addr.data, sizeof(laddr));
+ get_addr(&saddr, *argv, AF_INET6);
} else if (!matches(*argv, "dev")) {
NEXT_ARG();
link = ll_name_to_index(*argv);
@@ -398,8 +397,10 @@ get_failed:
addattr32(n, 1024, IFLA_GRE_OKEY, okey);
addattr_l(n, 1024, IFLA_GRE_IFLAGS, &iflags, 2);
addattr_l(n, 1024, IFLA_GRE_OFLAGS, &oflags, 2);
- addattr_l(n, 1024, IFLA_GRE_LOCAL, &laddr, sizeof(laddr));
- addattr_l(n, 1024, IFLA_GRE_REMOTE, &raddr, sizeof(raddr));
+ if (is_addrtype_inet(&saddr))
+ addattr_l(n, 1024, IFLA_GRE_LOCAL, saddr.data, saddr.bytelen);
+ if (is_addrtype_inet(&daddr))
+ addattr_l(n, 1024, IFLA_GRE_REMOTE, daddr.data, daddr.bytelen);
if (link)
addattr32(n, 1024, IFLA_GRE_LINK, link);
addattr_l(n, 1024, IFLA_GRE_TTL, &hop_limit, 1);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH iproute2-next 3/3] iptnl/ip6tnl: Unify local/remote endpoint and 6rd address parsing
2018-02-09 18:06 [PATCH iproute2-next 0/3] ip/tunnel: Unify local/remote endpoint address parsing Serhey Popovych
2018-02-09 18:06 ` [PATCH iproute2-next 1/3] vti/vti6: " Serhey Popovych
2018-02-09 18:06 ` [PATCH iproute2-next 2/3] gre/gre6: " Serhey Popovych
@ 2018-02-09 18:06 ` Serhey Popovych
2018-02-10 16:48 ` David Ahern
2 siblings, 1 reply; 5+ messages in thread
From: Serhey Popovych @ 2018-02-09 18:06 UTC (permalink / raw)
To: netdev
We are going to merge link_iptnl.c and link_ip6tnl.c and this is final
step to make their diffs clear and show what needs to be changed during
merge.
Note that it is safe to omit endpoint address(es) from netlink create
request as kernel is aware of such case and will use zero for that
endpoint(s).
Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
---
ip/link_ip6tnl.c | 39 +++++++++++----------
ip/link_iptnl.c | 103 +++++++++++++++++++++++++++---------------------------
2 files changed, 72 insertions(+), 70 deletions(-)
diff --git a/ip/link_ip6tnl.c b/ip/link_ip6tnl.c
index 8a45d42..5253086 100644
--- a/ip/link_ip6tnl.c
+++ b/ip/link_ip6tnl.c
@@ -93,8 +93,7 @@ static int ip6tunnel_parse_opt(struct link_util *lu, int argc, char **argv,
struct rtattr *linkinfo[IFLA_INFO_MAX+1];
struct rtattr *iptuninfo[IFLA_IPTUN_MAX + 1];
int len;
- struct in6_addr laddr = IN6ADDR_ANY_INIT;
- struct in6_addr raddr = IN6ADDR_ANY_INIT;
+ inet_prefix saddr, daddr;
__u8 hop_limit = DEFAULT_TNL_HOP_LIMIT;
__u8 encap_limit = IPV6_DEFAULT_TNL_ENCAP_LIMIT;
__u32 flowinfo = 0;
@@ -108,7 +107,11 @@ static int ip6tunnel_parse_opt(struct link_util *lu, int argc, char **argv,
__u8 metadata = 0;
__u32 fwmark = 0;
+ saddr.flags = daddr.flags = 0;
+
if (!(n->nlmsg_flags & NLM_F_CREATE)) {
+ const struct rtattr *rta;
+
if (rtnl_talk(&rth, &req.n, &answer) < 0) {
get_failed:
fprintf(stderr,
@@ -134,13 +137,13 @@ get_failed:
parse_rtattr_nested(iptuninfo, IFLA_IPTUN_MAX,
linkinfo[IFLA_INFO_DATA]);
- if (iptuninfo[IFLA_IPTUN_LOCAL])
- memcpy(&laddr, RTA_DATA(iptuninfo[IFLA_IPTUN_LOCAL]),
- sizeof(laddr));
+ rta = iptuninfo[IFLA_IPTUN_LOCAL];
+ if (rta && get_addr_rta(&saddr, rta, AF_INET6))
+ goto get_failed;
- if (iptuninfo[IFLA_IPTUN_REMOTE])
- memcpy(&raddr, RTA_DATA(iptuninfo[IFLA_IPTUN_REMOTE]),
- sizeof(raddr));
+ rta = iptuninfo[IFLA_IPTUN_REMOTE];
+ if (rta && get_addr_rta(&daddr, rta, AF_INET6))
+ goto get_failed;
if (iptuninfo[IFLA_IPTUN_TTL])
hop_limit = rta_getattr_u8(iptuninfo[IFLA_IPTUN_TTL]);
@@ -185,17 +188,11 @@ get_failed:
else
invarg("Cannot guess tunnel mode.", *argv);
} else if (strcmp(*argv, "remote") == 0) {
- inet_prefix addr;
-
NEXT_ARG();
- get_addr(&addr, *argv, AF_INET6);
- memcpy(&raddr, addr.data, sizeof(raddr));
+ get_addr(&daddr, *argv, AF_INET6);
} else if (strcmp(*argv, "local") == 0) {
- inet_prefix addr;
-
NEXT_ARG();
- get_addr(&addr, *argv, AF_INET6);
- memcpy(&laddr, addr.data, sizeof(laddr));
+ get_addr(&saddr, *argv, AF_INET6);
} else if (matches(*argv, "dev") == 0) {
NEXT_ARG();
link = ll_name_to_index(*argv);
@@ -322,8 +319,14 @@ get_failed:
return 0;
}
- addattr_l(n, 1024, IFLA_IPTUN_LOCAL, &laddr, sizeof(laddr));
- addattr_l(n, 1024, IFLA_IPTUN_REMOTE, &raddr, sizeof(raddr));
+ if (is_addrtype_inet(&saddr)) {
+ addattr_l(n, 1024, IFLA_IPTUN_LOCAL,
+ saddr.data, saddr.bytelen);
+ }
+ if (is_addrtype_inet(&daddr)) {
+ addattr_l(n, 1024, IFLA_IPTUN_REMOTE,
+ daddr.data, daddr.bytelen);
+ }
addattr8(n, 1024, IFLA_IPTUN_TTL, hop_limit);
addattr8(n, 1024, IFLA_IPTUN_ENCAP_LIMIT, encap_limit);
addattr32(n, 1024, IFLA_IPTUN_FLOWINFO, flowinfo);
diff --git a/ip/link_iptnl.c b/ip/link_iptnl.c
index bc1074e..e1f29bf 100644
--- a/ip/link_iptnl.c
+++ b/ip/link_iptnl.c
@@ -90,16 +90,11 @@ static int iptunnel_parse_opt(struct link_util *lu, int argc, char **argv,
struct rtattr *linkinfo[IFLA_INFO_MAX+1];
struct rtattr *iptuninfo[IFLA_IPTUN_MAX + 1];
int len;
- __u32 laddr = 0;
- __u32 raddr = 0;
+ inet_prefix saddr, daddr, ip6rdprefix, ip6rdrelayprefix;
__u8 pmtudisc = 1;
__u8 tos = 0;
__u16 iflags = 0;
__u8 ttl = 0;
- struct in6_addr ip6rdprefix = {};
- __u16 ip6rdprefixlen = 0;
- __u32 ip6rdrelayprefix = 0;
- __u16 ip6rdrelayprefixlen = 0;
__u8 proto = 0;
__u32 link = 0;
__u16 encaptype = 0;
@@ -109,7 +104,13 @@ static int iptunnel_parse_opt(struct link_util *lu, int argc, char **argv,
__u8 metadata = 0;
__u32 fwmark = 0;
+ saddr.flags = daddr.flags = 0;
+ ip6rdprefix.flags = ip6rdrelayprefix.flags = 0;
+ ip6rdprefix.bitlen = ip6rdrelayprefix.bitlen = 0;
+
if (!(n->nlmsg_flags & NLM_F_CREATE)) {
+ const struct rtattr *rta;
+
if (rtnl_talk(&rth, &req.n, &answer) < 0) {
get_failed:
fprintf(stderr,
@@ -135,11 +136,29 @@ get_failed:
parse_rtattr_nested(iptuninfo, IFLA_IPTUN_MAX,
linkinfo[IFLA_INFO_DATA]);
- if (iptuninfo[IFLA_IPTUN_LOCAL])
- laddr = rta_getattr_u32(iptuninfo[IFLA_IPTUN_LOCAL]);
+ rta = iptuninfo[IFLA_IPTUN_LOCAL];
+ if (rta && get_addr_rta(&saddr, rta, AF_INET))
+ goto get_failed;
+
+ rta = iptuninfo[IFLA_IPTUN_REMOTE];
+ if (rta && get_addr_rta(&daddr, rta, AF_INET))
+ goto get_failed;
+
+ rta = iptuninfo[IFLA_IPTUN_6RD_PREFIX];
+ if (rta && get_addr_rta(&ip6rdprefix, rta, AF_INET6))
+ goto get_failed;
+
+ rta = iptuninfo[IFLA_IPTUN_6RD_RELAY_PREFIX];
+ if (rta && get_addr_rta(&ip6rdrelayprefix, rta, AF_INET))
+ goto get_failed;
- if (iptuninfo[IFLA_IPTUN_REMOTE])
- raddr = rta_getattr_u32(iptuninfo[IFLA_IPTUN_REMOTE]);
+ rta = iptuninfo[IFLA_IPTUN_6RD_PREFIXLEN];
+ if (rta)
+ ip6rdprefix.bitlen = rta_getattr_u16(rta);
+
+ rta = iptuninfo[IFLA_IPTUN_6RD_RELAY_PREFIXLEN];
+ if (rta)
+ ip6rdrelayprefix.bitlen = rta_getattr_u16(rta);
if (iptuninfo[IFLA_IPTUN_TTL])
ttl = rta_getattr_u8(iptuninfo[IFLA_IPTUN_TTL]);
@@ -168,22 +187,7 @@ get_failed:
encapsport = rta_getattr_u16(iptuninfo[IFLA_IPTUN_ENCAP_SPORT]);
if (iptuninfo[IFLA_IPTUN_ENCAP_DPORT])
encapdport = rta_getattr_u16(iptuninfo[IFLA_IPTUN_ENCAP_DPORT]);
- if (iptuninfo[IFLA_IPTUN_6RD_PREFIX])
- memcpy(&ip6rdprefix,
- RTA_DATA(iptuninfo[IFLA_IPTUN_6RD_PREFIX]),
- sizeof(laddr));
-
- if (iptuninfo[IFLA_IPTUN_6RD_PREFIXLEN])
- ip6rdprefixlen =
- rta_getattr_u16(iptuninfo[IFLA_IPTUN_6RD_PREFIXLEN]);
-
- if (iptuninfo[IFLA_IPTUN_6RD_RELAY_PREFIX])
- ip6rdrelayprefix =
- rta_getattr_u32(iptuninfo[IFLA_IPTUN_6RD_RELAY_PREFIX]);
-
- if (iptuninfo[IFLA_IPTUN_6RD_RELAY_PREFIXLEN])
- ip6rdrelayprefixlen =
- rta_getattr_u16(iptuninfo[IFLA_IPTUN_6RD_RELAY_PREFIXLEN]);
+
if (iptuninfo[IFLA_IPTUN_COLLECT_METADATA])
metadata = 1;
@@ -214,10 +218,10 @@ get_failed:
invarg("Cannot guess tunnel mode.", *argv);
} else if (strcmp(*argv, "remote") == 0) {
NEXT_ARG();
- raddr = get_addr32(*argv);
+ get_addr(&daddr, *argv, AF_INET);
} else if (strcmp(*argv, "local") == 0) {
NEXT_ARG();
- laddr = get_addr32(*argv);
+ get_addr(&saddr, *argv, AF_INET);
} else if (matches(*argv, "dev") == 0) {
NEXT_ARG();
link = ll_name_to_index(*argv);
@@ -289,29 +293,16 @@ get_failed:
} else if (strcmp(*argv, "external") == 0) {
metadata = 1;
} else if (strcmp(*argv, "6rd-prefix") == 0) {
- inet_prefix prefix;
-
NEXT_ARG();
- if (get_prefix(&prefix, *argv, AF_INET6))
+ if (get_prefix(&ip6rdprefix, *argv, AF_INET6))
invarg("invalid 6rd_prefix\n", *argv);
- memcpy(&ip6rdprefix, prefix.data, 16);
- ip6rdprefixlen = prefix.bitlen;
} else if (strcmp(*argv, "6rd-relay_prefix") == 0) {
- inet_prefix prefix;
-
NEXT_ARG();
- if (get_prefix(&prefix, *argv, AF_INET))
+ if (get_prefix(&ip6rdrelayprefix, *argv, AF_INET))
invarg("invalid 6rd-relay_prefix\n", *argv);
- memcpy(&ip6rdrelayprefix, prefix.data, 4);
- ip6rdrelayprefixlen = prefix.bitlen;
} else if (strcmp(*argv, "6rd-reset") == 0) {
- inet_prefix prefix;
-
- get_prefix(&prefix, "2002::", AF_INET6);
- memcpy(&ip6rdprefix, prefix.data, 16);
- ip6rdprefixlen = 16;
- ip6rdrelayprefix = 0;
- ip6rdrelayprefixlen = 0;
+ get_prefix(&ip6rdprefix, "2002::/16", AF_INET6);
+ ip6rdrelayprefix.flags = 0;
} else if (strcmp(*argv, "fwmark") == 0) {
NEXT_ARG();
if (get_u32(&fwmark, *argv, 0))
@@ -334,8 +325,14 @@ get_failed:
return 0;
}
- addattr32(n, 1024, IFLA_IPTUN_LOCAL, laddr);
- addattr32(n, 1024, IFLA_IPTUN_REMOTE, raddr);
+ if (is_addrtype_inet(&saddr)) {
+ addattr_l(n, 1024, IFLA_IPTUN_LOCAL,
+ saddr.data, saddr.bytelen);
+ }
+ if (is_addrtype_inet(&daddr)) {
+ addattr_l(n, 1024, IFLA_IPTUN_REMOTE,
+ daddr.data, daddr.bytelen);
+ }
addattr8(n, 1024, IFLA_IPTUN_PMTUDISC, pmtudisc);
addattr8(n, 1024, IFLA_IPTUN_TOS, tos);
addattr8(n, 1024, IFLA_IPTUN_TTL, ttl);
@@ -349,15 +346,17 @@ get_failed:
if (strcmp(lu->id, "sit") == 0) {
addattr16(n, 1024, IFLA_IPTUN_FLAGS, iflags);
- if (ip6rdprefixlen) {
+ if (is_addrtype_inet(&ip6rdprefix)) {
addattr_l(n, 1024, IFLA_IPTUN_6RD_PREFIX,
- &ip6rdprefix, sizeof(ip6rdprefix));
+ ip6rdprefix.data, ip6rdprefix.bytelen);
addattr16(n, 1024, IFLA_IPTUN_6RD_PREFIXLEN,
- ip6rdprefixlen);
+ ip6rdprefix.bitlen);
+ }
+ if (is_addrtype_inet(&ip6rdrelayprefix)) {
addattr32(n, 1024, IFLA_IPTUN_6RD_RELAY_PREFIX,
- ip6rdrelayprefix);
+ ip6rdrelayprefix.data[0]);
addattr16(n, 1024, IFLA_IPTUN_6RD_RELAY_PREFIXLEN,
- ip6rdrelayprefixlen);
+ ip6rdrelayprefix.bitlen);
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH iproute2-next 3/3] iptnl/ip6tnl: Unify local/remote endpoint and 6rd address parsing
2018-02-09 18:06 ` [PATCH iproute2-next 3/3] iptnl/ip6tnl: Unify local/remote endpoint and 6rd " Serhey Popovych
@ 2018-02-10 16:48 ` David Ahern
0 siblings, 0 replies; 5+ messages in thread
From: David Ahern @ 2018-02-10 16:48 UTC (permalink / raw)
To: Serhey Popovych, netdev
On 2/9/18 11:06 AM, Serhey Popovych wrote:
> @@ -289,29 +293,16 @@ get_failed:
> } else if (strcmp(*argv, "external") == 0) {
> metadata = 1;
> } else if (strcmp(*argv, "6rd-prefix") == 0) {
> - inet_prefix prefix;
> -
> NEXT_ARG();
> - if (get_prefix(&prefix, *argv, AF_INET6))
> + if (get_prefix(&ip6rdprefix, *argv, AF_INET6))
> invarg("invalid 6rd_prefix\n", *argv);
> - memcpy(&ip6rdprefix, prefix.data, 16);
> - ip6rdprefixlen = prefix.bitlen;
> } else if (strcmp(*argv, "6rd-relay_prefix") == 0) {
> - inet_prefix prefix;
> -
> NEXT_ARG();
> - if (get_prefix(&prefix, *argv, AF_INET))
> + if (get_prefix(&ip6rdrelayprefix, *argv, AF_INET))
> invarg("invalid 6rd-relay_prefix\n", *argv);
> - memcpy(&ip6rdrelayprefix, prefix.data, 4);
> - ip6rdrelayprefixlen = prefix.bitlen;
> } else if (strcmp(*argv, "6rd-reset") == 0) {
> - inet_prefix prefix;
> -
> - get_prefix(&prefix, "2002::", AF_INET6);
> - memcpy(&ip6rdprefix, prefix.data, 16);
> - ip6rdprefixlen = 16;
> - ip6rdrelayprefix = 0;
> - ip6rdrelayprefixlen = 0;
> + get_prefix(&ip6rdprefix, "2002::/16", AF_INET6);
> + ip6rdrelayprefix.flags = 0;
> } else if (strcmp(*argv, "fwmark") == 0) {
> NEXT_ARG();
> if (get_u32(&fwmark, *argv, 0))
I spent far too long staring at the patches to verify you are not
breaking anything. A key reason is the reset of inet_prefix.flags to 0.
That is a low-level detail that needs a properly named helper to make it
clear you are resetting the address to uninitialized.
That is needed in all of the places you have 'inet_prefix.flags = 0;' in
these.
^ permalink raw reply [flat|nested] 5+ messages in thread