Re: [PATCH net-next v3 1/6] net: sched: introduce qdisc-specific drop reason tracing

[Paolo Abeni <pabeni@redhat.com>]

On 2/11/26 9:36 AM, Paolo Abeni wrote:
> On 2/6/26 5:24 PM, Jesper Dangaard Brouer wrote:
>> @@ -593,7 +591,7 @@ static struct sk_buff *dualpi2_qdisc_dequeue(struct Qdisc *sch)
>>  	while ((skb = dequeue_packet(sch, q, &credit_change, now))) {
>>  		if (!q->drop_early && must_drop(sch, q, skb)) {
>>  			drop_and_retry(q, skb, sch,
>> -				       SKB_DROP_REASON_QDISC_CONGESTED);
>> +				       QDISC_DROP_CONGESTED);
> 
> An explicit cast is needed above to avoid compiler warning (or you can
> change drop_and_retry() signature).

I see that the type confusion issues are handled for good by later
patches in the series, but I still think it would be better to avoid
introducing them with explicit casts as needed (removed by later patches).

> Also a few lines below there is another drop_and_retry() calls that is
> not converted.

I see it's handled by a later patch. I guess it would be useful to
mention such fact in the commit message.

Thanks,

Paolo