From: Paolo Abeni <pabeni@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, mkubecek@suse.cz
Subject: Re: [PATCH net-next 1/2] ethtool: netlink: handle SET intro/outro in the common code
Date: Tue, 24 Jan 2023 12:34:23 +0100 [thread overview]
Message-ID: <ddb7520869c8143ea6bf3fc99716e4369d2518db.camel@redhat.com> (raw)
In-Reply-To: <20230121054430.642280-1-kuba@kernel.org>
Hi,
On Fri, 2023-01-20 at 21:44 -0800, Jakub Kicinski wrote:
> diff --git a/net/ethtool/pause.c b/net/ethtool/pause.c
> index a8c113d244db..8e9aced3eeec 100644
> --- a/net/ethtool/pause.c
> +++ b/net/ethtool/pause.c
> @@ -114,18 +114,6 @@ static int pause_fill_reply(struct sk_buff *skb,
> return 0;
> }
>
> -const struct ethnl_request_ops ethnl_pause_request_ops = {
> - .request_cmd = ETHTOOL_MSG_PAUSE_GET,
> - .reply_cmd = ETHTOOL_MSG_PAUSE_GET_REPLY,
> - .hdr_attr = ETHTOOL_A_PAUSE_HEADER,
> - .req_info_size = sizeof(struct pause_req_info),
> - .reply_data_size = sizeof(struct pause_reply_data),
> -
> - .prepare_data = pause_prepare_data,
> - .reply_size = pause_reply_size,
> - .fill_reply = pause_fill_reply,
> -};
> -
> /* PAUSE_SET */
>
> const struct nla_policy ethnl_pause_set_policy[] = {
This chunk does not apply cleanly due to commit 04692c9020b7 ("net:
ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)")
Could you please rebase?
Thanks!
Paolo
next prev parent reply other threads:[~2023-01-24 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 5:44 [PATCH net-next 1/2] ethtool: netlink: handle SET intro/outro in the common code Jakub Kicinski
2023-01-21 5:44 ` [PATCH net-next 2/2] ethtool: netlink: convert commands to common SET Jakub Kicinski
2023-01-23 8:00 ` Gal Pressman
2023-01-23 11:20 ` Tariq Toukan
2023-01-23 12:17 ` Daniele Palmas
2023-01-24 11:41 ` Paolo Abeni
2023-01-24 11:34 ` Paolo Abeni [this message]
2023-01-25 0:37 ` [PATCH net-next 1/2] ethtool: netlink: handle SET intro/outro in the common code Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddb7520869c8143ea6bf3fc99716e4369d2518db.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).