From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Subject: Re: [PATCH net-next] ip6_vti: adjust vti mtu according to mtu of output device Date: Fri, 8 Dec 2017 15:25:07 -0800 Message-ID: References: <1512578299-7573-1-git-send-email-alexey.kodanev@oracle.com> <20171208070215.nycywbhkd4u7twh7@gauss3.secunet.de> <1d086bbe-8d90-628f-4622-2fdb5fb1405e@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, David Miller , Petr Vorel To: Alexey Kodanev , Steffen Klassert Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:45790 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753112AbdLHXZS (ORCPT ); Fri, 8 Dec 2017 18:25:18 -0500 In-Reply-To: <1d086bbe-8d90-628f-4622-2fdb5fb1405e@oracle.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/8/2017 3:54 AM, Alexey Kodanev wrote: > On 12/08/2017 10:02 AM, Steffen Klassert wrote: >> On Wed, Dec 06, 2017 at 07:38:19PM +0300, Alexey Kodanev wrote: Since you're planning to do a 2nd version anyway, can we get a couple of the commit message issues cleaned up? >>> LTP/udp6_ipsec_vti tests fail when sending large UDP datagrams >>> that require fragmentation and underlying device MTU <= 1500. s/underlying device/the underlying device has/ >>> This happens because ip6_vti sets mtu to ETH_DATA_LEN and not >>> updating it depending on a destiantion address. s/destiantion/destination/ >>> >>> Futhure attempts to send UDP packets may succeed because pmtu s/Futhure/Further/ >>> get updated on ICMPV6_PKT_TOOBIG in vti6_err(). s/get/gets/ >>> >>> Here is the example when output device MTU set to 9000: s/output device MTU/the output device MTU is/ Thanks, sln