From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands Date: Wed, 28 Nov 2018 14:07:29 -0600 Message-ID: References: <7026be07534b14fd74e592c315523c57fde05a0a.1543422310.git.swise@opengridcomputing.com> <20181128182645.GJ4559@mtr-leonro.mtl.com> <20181128200412.GP4559@mtr-leonro.mtl.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: dsahern@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, BMT@zurich.ibm.com To: Leon Romanovsky Return-path: Received: from opengridcomputing.com ([72.48.214.68]:36684 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbeK2HKO (ORCPT ); Thu, 29 Nov 2018 02:10:14 -0500 In-Reply-To: <20181128200412.GP4559@mtr-leonro.mtl.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/28/2018 2:04 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: >> >> On 11/28/2018 12:26 PM, Leon Romanovsky wrote: >>> On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: >>>> Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma >>>> device to a netdev interface. >>>> >>>> EG: >>>> >>>> rdma link add rxe_eth0 type rxe dev eth0 >>>> rdma link delete rxe_eth0 >>>> >>>> Signed-off-by: Steve Wise >>>> --- >>>> rdma/link.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> rdma/rdma.h | 1 + >>>> rdma/utils.c | 2 +- >>>> 3 files changed, 108 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/rdma/link.c b/rdma/link.c >>>> index 7a6d4b7e356d..d4f76b0ce11f 100644 >>>> --- a/rdma/link.c >>>> +++ b/rdma/link.c >>>> @@ -14,6 +14,8 @@ >>>> static int link_help(struct rd *rd) >>>> { >>>> pr_out("Usage: %s link show [DEV/PORT_INDEX]\n", rd->filename); >>>> + pr_out("Usage: %s link add NAME type TYPE dev DEV\n", rd->filename); >>> I suggest to rename "dev" to be "netdev", because we are using "dev" for >>> ib devices. >> Yea ok. >> >>>> + pr_out("Usage: %s link delete NAME type TYPE\n", rd->filename); >>> Why do you need "type" for "delete" command? >> Because the type is used in the kernel to find the appropriate link >> ops.  I could change the kernel side to search all types for the device >> name to delete?  > I would say, yes. > It makes "delete" operation more natural. > > Thanks Perhaps. Note: 'ip link delete' takes a type as well...