netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Lord <mlord@pobox.com>
To: Hayes Wang <hayeswang@realtek.com>, David Miller <davem@davemloft.net>
Cc: nic_swsd <nic_swsd@realtek.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] r8152: Fix broken RX checksums.
Date: Thu, 3 Nov 2016 07:43:36 -0400	[thread overview]
Message-ID: <ddbc14e2-dfb5-01f2-0d5b-5b409a01160f@pobox.com> (raw)
In-Reply-To: <0835B3720019904CB8F7AA43166CEEB20104878A@RTITMBSV03.realtek.com.tw>

On 16-11-03 04:56 AM, Hayes Wang wrote:
> Mark Lord [mailto:mlord@pobox.com]
>> Sent: Thursday, November 03, 2016 2:30 AM
>> To: Hayes Wang; David Miller
> [...]
>> I have poked at it some more, and thus far it appears that it is
>> only necessary to disable TCP rx checksums.  The system doesn't crash
>> when only IP/UDP checksums are enabled, but does when TCP checksums are on.
>>
>> This happens regardless of whether RX_AGG is disabled or enabled,
>> and increasing/decreasing the number of RX URBs (RTL8152_MAX_RX)
>> doesn't seem to affect it.
> 
> I test Raspberry Pi v1, but I couldn't boot with NFSROOT through
> both onboard nic and RTL8152. I get following error.
> 
>    VFS: Unable to mount root fs via NFS, trying floppy.
>    Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(2,0)
> 
> However, if I start the system without NFSROOT, I could mount the nfs fs.
> Any idea?

Rather than getting caught up in all of that,
you could then just chroot to the mounted nfs fs
at that point, and continue on from there.

Eg.  chroot /mnt/nfsxxx /bin/sh

Running from NFS is probably not necessary though.
Instead, perhaps just run md5sum on every file on the nfs fs
from the Raspberry Pi, and then repeat the md5sum's on the server,
and compare the results for errors.

The system I am using the dongle with is a custom embedded board,
but I think the important thing is that it has a slow-ish CPU,
which means it is more prone to having the on-chip RX FIFO overflow.
It is also big-endian rather than little-endian, though that seems
to be correctly handled already in the device driver.

I will try the md5sum test on an x86 box for comparison.

Cheers
-- 
Mark Lord

  reply	other threads:[~2016-11-03 11:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 22:36 [PATCH] drivers/net/usb/r8152 fix broken rx checksums Mark Lord
2016-10-26 22:54 ` Mark Lord
2016-10-30 21:22 ` David Miller
2016-10-30 23:48   ` Paul Bolle
2016-10-30 23:28 ` [PATCH net] r8152: Fix broken RX checksums Mark Lord
2016-10-31  0:57   ` David Miller
2016-10-31  2:07     ` Mark Lord
2016-10-31  3:53       ` David Miller
2016-10-31  8:14         ` Hayes Wang
2016-10-31 13:24           ` Mark Lord
2016-11-02 18:29           ` Mark Lord
2016-11-04 12:13             ` Mark Lord
     [not found]           ` <201611030159.uA31x0np004648@rtits1.realtek.com>
2016-11-03  8:56             ` Hayes Wang
2016-11-03 11:43               ` Mark Lord [this message]
2016-11-04 13:50                 ` Mark Lord
2016-11-04 20:13                   ` Mark Lord
     [not found]                 ` <201611041425.uA4EPwCw018176@rtits1.realtek.com>
2016-11-09 13:09                   ` Hayes Wang
2016-11-09 13:19                     ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddbc14e2-dfb5-01f2-0d5b-5b409a01160f@pobox.com \
    --to=mlord@pobox.com \
    --cc=davem@davemloft.net \
    --cc=hayeswang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).