From: Andrew Lunn <andrew@lunn.ch>
To: Kyle Switch <kyle.switch@motor-comm.com>
Cc: Frank.Sae@motor-comm.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.xu@motor-comm.com,
xiaolin.xu@motor-comm.com, jianmin.wang@motor-comm.com,
jie.han@motor-comm.com
Subject: Re: [PATCH net-next v11] net: phy: Add driver for Motorcomm Quad 2.5GbE phy
Date: Tue, 18 Aug 2026 03:13:14 +0200 [thread overview]
Message-ID: <ddcf52a2-fba3-442e-bd82-106cf7f48ea2@lunn.ch> (raw)
In-Reply-To: <20260817110626.510277-1-kyle.switch@motor-comm.com>
> + if (link) {
> + phydev->link = 1;
> + phydev->pause = !!(lpa & BIT(10));
> + phydev->asym_pause = !!(lpa & BIT(11));
This is wrong.
Where do you see any other driver doing this?
phy_resolve_aneg_pause() will set phydev->pause and
phydev->asym_pause.
You should be trying to use genphy_read_status() to do most of the
work, and then mix in the 2.5G status information afterwards.
Andrew
prev parent reply other threads:[~2026-08-18 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 11:06 [PATCH net-next v11] net: phy: Add driver for Motorcomm Quad 2.5GbE phy Kyle Switch
2026-08-17 15:37 ` Jakub Kicinski
2026-08-18 1:13 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddcf52a2-fba3-442e-bd82-106cf7f48ea2@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jianmin.wang@motor-comm.com \
--cc=jie.han@motor-comm.com \
--cc=kuba@kernel.org \
--cc=kyle.switch@motor-comm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ming.xu@motor-comm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaolin.xu@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox