From: David Ahern <dsahern@gmail.com>
To: Vlad Buslov <vlad@buslov.dev>,
jhs@mojatatu.com, netdev@vger.kernel.org,
stephen@networkplumber.org
Cc: davem@davemloft.net, kuba@kernel.org, xiyou.wangcong@gmail.com,
jiri@resnulli.us
Subject: Re: [PATCH iproute2-next] tc: implement support for action terse dump
Date: Mon, 2 Nov 2020 18:48:12 -0700 [thread overview]
Message-ID: <ddd99541-204c-1b29-266f-2d7f4489d403@gmail.com> (raw)
In-Reply-To: <20201031202522.247924-1-vlad@buslov.dev>
On 10/31/20 2:25 PM, Vlad Buslov wrote:
> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> index 5ad84e663d01..b486f52900f0 100644
> --- a/include/uapi/linux/rtnetlink.h
> +++ b/include/uapi/linux/rtnetlink.h
> @@ -768,8 +768,12 @@ enum {
> * actions in a dump. All dump responses will contain the number of actions
> * being dumped stored in for user app's consumption in TCA_ROOT_COUNT
> *
> + * TCA_FLAG_TERSE_DUMP user->kernel to request terse (brief) dump that only
> + * includes essential action info (kind, index, etc.)
> + *
> */
> #define TCA_FLAG_LARGE_DUMP_ON (1 << 0)
> +#define TCA_FLAG_TERSE_DUMP (1 << 1)
>
there is an existing TCA_DUMP_FLAGS_TERSE. How does this differ and if
it really is needed please make it different enough and documented to
avoid confusion.
next prev parent reply other threads:[~2020-11-03 1:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 20:16 [PATCH net-next] net: sched: implement action-specific terse dump Vlad Buslov
2020-10-31 20:25 ` [PATCH iproute2-next] tc: implement support for action " Vlad Buslov
2020-11-03 1:48 ` David Ahern [this message]
2020-11-03 15:07 ` Vlad Buslov
2020-11-03 21:59 ` Jamal Hadi Salim
2020-11-06 19:16 ` Vlad Buslov
2020-11-06 20:25 ` David Ahern
2020-11-06 20:36 ` Jakub Kicinski
2020-11-02 12:26 ` [PATCH net-next] net: sched: implement action-specific " Jamal Hadi Salim
2020-11-02 20:00 ` Vlad Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddd99541-204c-1b29-266f-2d7f4489d403@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vlad@buslov.dev \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).