From: Jon Maloy <jmaloy@redhat.com>
To: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
tipc-discussion@lists.sourceforge.net
Cc: davem@davemloft.net, kuba@kernel.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Ying Xue <ying.xue@windriver.com>,
Wei Chen <harperchen1110@gmail.com>
Subject: Re: [PATCH net 0/2] tipc: fix two race issues in tipc_conn_alloc
Date: Mon, 21 Nov 2022 19:47:18 -0500 [thread overview]
Message-ID: <ddde1e8f-4970-cc4b-144a-647679dbd1bb@redhat.com> (raw)
In-Reply-To: <cover.1668807842.git.lucien.xin@gmail.com>
On 11/18/22 16:44, Xin Long wrote:
> The race exists beteen tipc_topsrv_accept() and tipc_conn_close(),
> one is allocating the con while the other is freeing it and there
> is no proper lock protecting it. Therefore, a null-pointer-defer
> and a use-after-free may be triggered, see details on each patch.
>
> Xin Long (2):
> tipc: set con sock in tipc_conn_alloc
> tipc: add an extra conn_get in tipc_conn_alloc
>
> net/tipc/topsrv.c | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
Series
Acked-by: Jon Maloy <jmaloy@redhat.com>
next prev parent reply other threads:[~2022-11-22 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 21:44 [PATCH net 0/2] tipc: fix two race issues in tipc_conn_alloc Xin Long
2022-11-18 21:45 ` [PATCH net 1/2] tipc: set con sock " Xin Long
2022-11-18 21:45 ` [PATCH net 2/2] tipc: add an extra conn_get " Xin Long
2022-11-22 0:47 ` Jon Maloy [this message]
2022-11-22 5:00 ` [PATCH net 0/2] tipc: fix two race issues " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddde1e8f-4970-cc4b-144a-647679dbd1bb@redhat.com \
--to=jmaloy@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=harperchen1110@gmail.com \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).