From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Simon Horman <horms@kernel.org>, <joshua.a.hay@intel.com>,
<aaron.ma@canonical.com>, <przemyslaw.kitszel@intel.com>,
<Samuel.salin@intel.com>, <jacob.e.keller@intel.com>,
<pmenzel@molgen.mpg.de>, <sridhar.samudrala@intel.com>,
<brett.creeley@amd.com>, <decot@google.com>,
<david.m.ertman@intel.com>, <andrew+netdev@lunn.ch>,
<netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<sreedevi.joshi@intel.com>, <rafal.romanowski@intel.com>,
<en-wei.wu@canonical.com>, <dima.ruinskiy@intel.com>,
<michal.kubiak@intel.com>, <tglx@kernel.org>, <pabeni@redhat.com>,
<willemb@google.com>, <avigailx.dahan@intel.com>,
<davem@davemloft.net>, <aleksandr.loktionov@intel.com>,
<edumazet@google.com>, <piotr.kwapulinski@intel.com>,
<sx.rinitha@intel.com>, <emil.s.tantilov@intel.com>,
<brianvv@google.com>, <vitaly.lifshits@intel.com>,
<jedrzej.jagielski@intel.com>, <stable@vger.kernel.org>,
<richardcochran@gmail.com>, <joe@dama.to>, <mschmidt@redhat.com>,
<boolli@google.com>
Subject: Re: [net,13/13] e1000e: correct TIMINCA on ADP/TGP systems with wrong XTAL frequency
Date: Wed, 25 Feb 2026 10:42:51 -0800 [thread overview]
Message-ID: <de1e751c-d8ef-400d-81fe-12f9b7dd5bee@intel.com> (raw)
In-Reply-To: <20260224161125.4dc744eb@kernel.org>
On 2/24/2026 4:11 PM, Jakub Kicinski wrote:
> On Tue, 24 Feb 2026 14:59:36 -0800 Tony Nguyen wrote:
>> Yea, looks like we need to do some adjustments here. Also, the AI review
>> I just ran on this is reporting another issue that we'll need to look
>> into. I'm going to drop this one from the series to not hold the others
>> up on this.
>
> I'd sometimes apply series partially for y'all but FWIW the idpf
> "defensive programming instead of proper rollback" patches really
> don't make me want to interact with this series more than I have to.
> You don't have to rework them. Just expect some delays, I guess.
Hi Jakub,
Yea, when we reviewed them, we tried to come up with a solution to
suggest that wouldn't need the added checks but couldn't come up with
anything that wouldn't require large amounts of changes/refactoring.
I'll send out a new version without this last patch 😐
Thanks,
Tony
prev parent reply other threads:[~2026-02-25 18:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 0:40 [PATCH net 00/13][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) Tony Nguyen
2026-02-20 0:40 ` [PATCH net 01/13] idpf: increment completion queue next_to_clean in sw marker wait routine Tony Nguyen
2026-02-20 0:40 ` [PATCH net 02/13] idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL Tony Nguyen
2026-02-20 0:40 ` [PATCH net 03/13] idpf: skip deallocating txq group's txqs " Tony Nguyen
2026-02-20 0:40 ` [PATCH net 04/13] idpf: nullify pointers after they are freed Tony Nguyen
2026-02-20 0:40 ` [PATCH net 05/13] idpf: change IRQ naming to match netdev and ethtool queue numbering Tony Nguyen
2026-02-20 0:40 ` [PATCH net 06/13] idpf: Fix flow rule delete failure due to invalid validation Tony Nguyen
2026-02-20 0:40 ` [PATCH net 07/13] ice: recap the VSI and QoS info after rebuild Tony Nguyen
2026-02-20 0:40 ` [PATCH net 08/13] ice: fix crash in ethtool offline loopback test Tony Nguyen
2026-02-20 0:40 ` [PATCH net 09/13] i40e: Fix preempt count leak in napi poll tracepoint Tony Nguyen
2026-02-20 0:40 ` [PATCH net 10/13] ixgbevf: fix link setup issue Tony Nguyen
2026-02-20 0:40 ` [PATCH net 11/13] e1000e: introduce new board type for Panther Lake PCH Tony Nguyen
2026-02-20 0:40 ` [PATCH net 12/13] e1000e: clear DPG_EN after reset to avoid autonomous power-gating Tony Nguyen
2026-02-20 0:40 ` [PATCH net 13/13] e1000e: correct TIMINCA on ADP/TGP systems with wrong XTAL frequency Tony Nguyen
2026-02-22 16:28 ` [net,13/13] " Simon Horman
2026-02-24 22:59 ` Tony Nguyen
2026-02-25 0:11 ` Jakub Kicinski
2026-02-25 18:42 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1e751c-d8ef-400d-81fe-12f9b7dd5bee@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=Samuel.salin@intel.com \
--cc=aaron.ma@canonical.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=avigailx.dahan@intel.com \
--cc=boolli@google.com \
--cc=brett.creeley@amd.com \
--cc=brianvv@google.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=decot@google.com \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=en-wei.wu@canonical.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=joe@dama.to \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=michal.kubiak@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotr.kwapulinski@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=rafal.romanowski@intel.com \
--cc=richardcochran@gmail.com \
--cc=sreedevi.joshi@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=stable@vger.kernel.org \
--cc=sx.rinitha@intel.com \
--cc=tglx@kernel.org \
--cc=vitaly.lifshits@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox