Re: [PATCH v3 net-next 08/15] ipv4: Replace &arp_tbl with arp_table(net).

[Nikolay Aleksandrov <razor@blackwall.org>]

On 11/08/2026 05:23, Kuniyuki Iwashima wrote:
> We will allocate per-netns neigh_table in net->neigh_tables[].
> 
> Let's replace &arp_tbl with arp_table(net) and remove extern
> definition for arp_tbl.
> 
> Three notes:
> 
>    1. mlx5e_rep_netevent_event() and nfp_tun_neigh_event_handler()
>       have code assuming neigh_table other than &arp_tbl and
>       &nb_tbl, and the part is removed as it will be false once
>       per-netns table is allocated.
> 
>    2. prestera and rocker uses init_net because they set
>       dev->netns_immutable to true.
> 
>    3. mlx5e_tc_update_neigh_used_value() dereferences nhe->neigh_dev
>       in trace_mlx5e_tc_update_neigh_used_value().
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
> ---
> v2: Add note about mlx5e_tc_update_neigh_used_value()
> 
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: Elad Nachman <enachman@marvell.com>
> Cc: Saeed Mahameed <saeedm@nvidia.com>
> Cc: Tariq Toukan <tariqt@nvidia.com>
> Cc: Mark Bloch <mbloch@nvidia.com>
> Cc: Boris Pismenny <borisp@nvidia.com>
> Cc: Petr Machata <petrm@nvidia.com>
> Cc: Jiri Pirko <jiri@resnulli.us>
> Cc: Edward Cree <ecree.xilinx@gmail.com>
> Cc: Nikolay Aleksandrov <razor@blackwall.org>
> ---
>   drivers/infiniband/ulp/ipoib/ipoib_main.c     | 27 ++++--
>   .../marvell/prestera/prestera_router.c        | 10 ++-
>   .../mellanox/mlx5/core/en/rep/neigh.c         | 22 ++---
>   .../mellanox/mlx5/core/en/tc_tun_encap.c      | 23 ++---
>   .../mellanox/mlx5/core/en_accel/ipsec.c       |  6 +-
>   .../ethernet/mellanox/mlxsw/spectrum_router.c | 18 ++--
>   .../ethernet/mellanox/mlxsw/spectrum_span.c   |  5 +-
>   .../netronome/nfp/flower/tunnel_conf.c        | 10 +--
>   drivers/net/ethernet/rocker/rocker_main.c     |  2 +-
>   drivers/net/ethernet/rocker/rocker_ofdpa.c    |  2 +-
>   drivers/net/ethernet/sfc/tc_counters.c        |  6 +-
>   drivers/net/ethernet/sfc/tc_encap_actions.c   |  2 +-
>   drivers/net/vxlan/vxlan_core.c                | 10 ++-
>   include/net/arp.h                             |  6 +-
>   include/net/route.h                           |  7 +-
>   net/bridge/br_arp_nd_proxy.c                  |  2 +-
>   net/ipv4/arp.c                                | 88 +++++++++++--------
>   net/ipv4/devinet.c                            | 18 ++--
>   net/ipv4/fib_semantics.c                      |  5 +-
>   net/ipv4/route.c                              |  2 +-
>   20 files changed, 159 insertions(+), 112 deletions(-)
> 

Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>