From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3AAC282C3 for ; Thu, 24 Jan 2019 13:51:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BDD52184B for ; Thu, 24 Jan 2019 13:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727694AbfAXNvc (ORCPT ); Thu, 24 Jan 2019 08:51:32 -0500 Received: from m9784.mail.qiye.163.com ([220.181.97.84]:26736 "EHLO m9784.mail.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727556AbfAXNvb (ORCPT ); Thu, 24 Jan 2019 08:51:31 -0500 Received: from [192.168.0.107] (unknown [180.157.171.167]) by m9784.mail.qiye.163.com (Hmail) with ESMTPA id 5348D416E1; Thu, 24 Jan 2019 21:51:28 +0800 (CST) Subject: Re: [PATCH v3] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type To: Pablo Neira Ayuso , Florian Westphal Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, David Ahern References: <1547596431-31824-1-git-send-email-wenxu@ucloud.cn> <20190118142430.rsnru4hyrbsodobf@salvia> <20190118143208.42q5ifmidcvtphtt@breakpoint.cc> <20190118143503.3h2tv4fujl4w25mz@salvia> From: wenxu Message-ID: Date: Thu, 24 Jan 2019 21:51:27 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190118143503.3h2tv4fujl4w25mz@salvia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-HM-Spam-Status: e1kIGBQJHllBS1VLV1koWUFJQjdXWS1ZQUlXWQkOFx4IWUFZMjUtOjcyP0 FLVUtZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6ODo6CTo*GjlKFRMdMk9WMBch Dy8KClZVSlVKTk9DSEhMQ0NDTkNJVTMWGhIXVQweFQMOOw4YFxQOH1UYFUVZV1kSC1lBWUpDS1VK TkxVSkxKVUpNTFlXWQgBWUFJTUhMNwY+ X-HM-Tid: 0a6880213d122086kuqy5348d416e1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi all, Are there any other idear for this patch?  Maye should modify  IFNAMSIZ to MODULE_NAME_LEN BR wenxu On 2019/1/18 下午10:35, Pablo Neira Ayuso wrote: > On Fri, Jan 18, 2019 at 03:32:08PM +0100, Florian Westphal wrote: >> Pablo Neira Ayuso wrote: >>>> + case NFT_META_IIFKIND: >>>> + if (in == NULL || in->rtnl_link_ops == NULL) >>>> + goto err; >>>> + strncpy((char *)dest, in->rtnl_link_ops->kind, IFNAMSIZ); >>> It seems kind can be arbitrarily large, no limitation in its length. >> Its limited to 60 or 56 bytes it seems: >> char kind[MODULE_NAME_LEN]; >> >> nla_strlcpy(kind, linfo[IFLA_INFO_KIND], sizeof(kind)); >> >> (linkinfo_to_kind_ops in rtnetlink.c). >> >>> Thinking... >>> >>> There is no other way to identify a vft device rather than this >>> string? The only l3mdev that exists if vrf, right? >> There is, I suggested this more generic approach, as it would allow >> to create rules that match on the kind of device used (vrf, ppp, etc.). > Ah I see. > >> If you think its too generic, ok. > I think it's fine, thanks for explaining. >