From: David Ahern <dsahern@gmail.com>
To: Wei Wang <weiwan@google.com>, David Ahern <dsahern@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
idosch@mellanox.com, saeedm@mellanox.com,
Martin KaFai Lau <kafai@fb.com>
Subject: Re: [PATCH v2 net-next 4/7] ipv6: Plumb support for nexthop object in a fib6_info
Date: Mon, 3 Jun 2019 12:37:48 -0600 [thread overview]
Message-ID: <de758bfa-4c20-9d40-58d8-c5ae07b40ff3@gmail.com> (raw)
In-Reply-To: <CAEA6p_AgK08iXuSBbMDqzatGaJj_UFbNWiBV-dQp2r-Y71iesw@mail.gmail.com>
On 6/3/19 12:09 PM, Wei Wang wrote:
>> @@ -667,6 +704,13 @@ static void __remove_nexthop_fib(struct net *net, struct nexthop *nh)
>> }
>> if (do_flush)
>> fib_flush(net);
>> +
>> + /* ip6_del_rt removes the entry from this list hence the _safe */
>> + list_for_each_entry_safe(f6i, tmp, &nh->f6i_list, nh_list) {
>> + /* __ip6_del_rt does a release, so do a hold here */
>> + fib6_info_hold(f6i);
> Do we need fib6_info_hold_safe() here?
>
I do not think so.
If it is on the f6i_list, then fib6_purge_rt has not been called.
fib6_purge_rt and this function are both called with rtnl held, so there
is no race with the removal from the list.
next prev parent reply other threads:[~2019-06-03 18:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 4:08 [PATCH v2 net-next 0/7] net: add struct nexthop to fib{6}_info David Ahern
2019-06-03 4:08 ` [PATCH v2 net-next 1/7] ipv4: Use accessors for fib_info nexthop data David Ahern
2019-06-03 4:08 ` [PATCH v2 net-next 2/7] ipv4: Prepare for fib6_nh from a nexthop object David Ahern
2019-06-03 4:08 ` [PATCH v2 net-next 3/7] ipv4: Plumb support for nexthop object in a fib_info David Ahern
2019-06-03 4:08 ` [PATCH v2 net-next 4/7] ipv6: Plumb support for nexthop object in a fib6_info David Ahern
2019-06-03 18:09 ` Wei Wang
2019-06-03 18:37 ` David Ahern [this message]
2019-06-03 20:42 ` David Ahern
2019-06-03 21:58 ` Wei Wang
2019-06-03 22:35 ` David Ahern
2019-06-03 23:05 ` Wei Wang
2019-06-03 23:18 ` David Ahern
2019-06-03 23:30 ` Wei Wang
2019-06-04 0:58 ` Martin Lau
2019-06-04 1:36 ` David Ahern
2019-06-04 5:29 ` Martin Lau
2019-06-04 20:17 ` David Ahern
2019-06-04 21:06 ` Martin Lau
2019-06-04 21:13 ` David Ahern
2019-06-04 21:36 ` Wei Wang
2019-06-04 23:30 ` David Ahern
2019-06-05 0:39 ` Martin Lau
2019-06-05 2:05 ` David Ahern
2019-06-05 6:01 ` Martin Lau
2019-06-04 21:53 ` Martin Lau
2019-06-03 4:08 ` [PATCH v2 net-next 5/7] mlxsw: Fail attempts to use routes with nexthop objects David Ahern
2019-06-03 4:08 ` [PATCH v2 net-next 6/7] mlx5: " David Ahern
2019-06-03 4:08 ` [PATCH v2 net-next 7/7] rocker: " David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de758bfa-4c20-9d40-58d8-c5ae07b40ff3@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=idosch@mellanox.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).