From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AF072231C for ; Sun, 7 Apr 2024 17:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712510814; cv=none; b=QUEqPK+eSgIARdhS6JUP5Hn/sRBtnFmlDussHnNXQEEXPWfdaPVHjNn4HpP/0GlPGs4fmq2RUhNcwg7jBH55PkDxm1jOrCOwQUw61znf8UJ6z6GXbQKM8Q1p5y7iGkqsp7Y5qDRQHm6OkH8VHULKwa6Iov755NOi6eJyUVDoeHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712510814; c=relaxed/simple; bh=/VqsvBFwghrPLkX3zuCvhWp/gKD/Bee2/h48i5AOCOg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UaqOzrcGmR8Jf0EKje967XTV07U6gXarTkWNtTjvhqCburwkxo3+b0H+Q6Mf3PFvus1wQqcbcbSbvh/H6AM33GThEuR6D0t5K2F8ZwuMTz2OsdObfpYMv/8o7ijs9IhnP5Un6n55v1QsASN26TeixU9tmMCR3S16AIdN3lAkAB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=MIvcAYR6; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="MIvcAYR6" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=YWay0V2bZ277152w7TiWjmD5EYN7YDnFFqruQZHdvNI=; b=MIvcAYR6UjIBbhakVGRKfQvpar gL/cf6Ty+EC66C2/ezJ5VyY+Lu8sQ130gJ7L8ROPPO4aVN4WHS4AUMWt2JKG3yT2XDmS0OYLghyWT EjzUBRXP+HeIfNa2UXHzbGWbCACqWSGETKHbKRkKiQodohuZIOKu+BwNLASHu4g9eF+k=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rtWHs-00CQzk-Nx; Sun, 07 Apr 2024 19:26:36 +0200 Date: Sun, 7 Apr 2024 19:26:36 +0200 From: Andrew Lunn To: Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Gregory Clement Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next v4 4/8] net: Add helpers for netdev LEDs Message-ID: References: <20240406-v6-8-0-net-next-mv88e6xxx-leds-v4-v4-0-eb97665e7f96@lunn.ch> <20240406-v6-8-0-net-next-mv88e6xxx-leds-v4-v4-4-eb97665e7f96@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240406-v6-8-0-net-next-mv88e6xxx-leds-v4-v4-4-eb97665e7f96@lunn.ch> > +/** > + * netdev_leds_setup - Parse DT node and create LEDs for netdev > + * > + * @ndev: struct netdev for the MAC > + * @np: ethernet-node in device tree > + * @list: list to add LEDs to > + * @ops: structure of ops to manipulate the LED. > + * @max_leds: maximum number of LEDs support by netdev. > + * > + * Parse the device tree node, as described in > + * ethernet-controller.yaml, and find any LEDs. For each LED found, > + * ensure the reg value is less than max_leds, create an LED and > + * register it with the LED subsystem. The LED will be added to the > + * list, which should be unique to the netdev. The ops structure > + * contains the callbacks needed to control the LEDs. > + * > + * Return 0 in success, otherwise an negative error code. There is a missing : here, which causes kdoc warnings. I will wait a couple of days for other comments and then repost with this fixed. Andrew --- pw-bot: cr