Re: [net PATCH 1/2] net: phy: Cleanup handling of recent changes to phy_lookup_setting

[Alexander H Duyck <alexander.duyck@gmail.com>]

On Wed, 2025-04-02 at 09:00 +0200, Maxime Chevallier wrote:
> Hi Alexander,
> 
> On Tue, 01 Apr 2025 14:30:06 -0700
> Alexander Duyck <alexander.duyck@gmail.com> wrote:
> 
> > From: Alexander Duyck <alexanderduyck@fb.com>
> > 
> > The blamed commit introduced an issue where it was limiting the link
> > configuration so that we couldn't use fixed-link mode for any settings
> > other than twisted pair modes 10G or less. As a result this was causing the
> > driver to lose any advertised/lp_advertised/supported modes when setup as a
> > fixed link.
> > 
> > To correct this we can add a check to identify if the user is in fact
> > enabling a TP mode and then apply the mask to select only 1 of each speed
> > for twisted pair instead of applying this before we know the number of bits
> > set.
> 
> The commit title should be :
> 
> 	net: phylink: ...
> 
> > Fixes: de7d3f87be3c ("net: phylink: Use phy_caps_lookup for fixed-link configuration")
> > Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>
> 
> With that,
> 
> Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> 
> Maxime

If needed I can resubmit. I had realized it when I went to send the
cover letter and edited it in another terminal. I completely overlooked
that a change like that would have changed the commit ID so it stuck to
the original.

Thanks,

- Alex