From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE52DC32793 for ; Wed, 18 Jan 2023 13:14:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbjARNOR (ORCPT ); Wed, 18 Jan 2023 08:14:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbjARNNg (ORCPT ); Wed, 18 Jan 2023 08:13:36 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77A50CB52E for ; Wed, 18 Jan 2023 04:36:54 -0800 (PST) Received: from kwepemm600017.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NxlZw68sKz16Mm8; Wed, 18 Jan 2023 20:35:04 +0800 (CST) Received: from [10.67.101.149] (10.67.101.149) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 18 Jan 2023 20:36:48 +0800 Subject: Re: [PATCH net-next 2/2] net: hns3: add vf fault process in hns3 ras To: Paolo Abeni , Hao Lan , , Leon Romanovsky References: <20230113020829.48451-1-lanhao@huawei.com> <20230113020829.48451-3-lanhao@huawei.com> <504c2c6ba951859cbd007cfd441dde7de1a8f479.camel@redhat.com> CC: , , , , , , From: "wangjie (L)" Message-ID: Date: Wed, 18 Jan 2023 20:36:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <504c2c6ba951859cbd007cfd441dde7de1a8f479.camel@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.101.149] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2023/1/17 16:04, Paolo Abeni wrote: > Hello, > > On Fri, 2023-01-13 at 10:08 +0800, Hao Lan wrote: > [...] > >> +static void hclge_get_vf_fault_bitmap(struct hclge_desc *desc, >> + unsigned long *bitmap) >> +{ >> +#define HCLGE_FIR_FAULT_BYTES 24 >> +#define HCLGE_SEC_FAULT_BYTES 8 >> + >> + u8 *buff; >> + >> + memcpy(bitmap, desc[0].data, HCLGE_FIR_FAULT_BYTES); >> + buff = (u8 *)bitmap + HCLGE_FIR_FAULT_BYTES; >> + memcpy(buff, desc[1].data, HCLGE_SEC_FAULT_BYTES); >> +} > > The above works under the assumption that: > > HCLGE_FIR_FAULT_BYTES + HCLGE_SEC_FAULT_BYTES == BITS_TO_BYTES(HCLGE_VPORT_NUM) > > I think it's better to enforce such condition at build time with a > BUILD_BUG_ON(), to avoid future issues. > OK, I will add it in v2 > Also I think Leon still deserve a reply to one of his questions, > specifically: What will happen (at recovery time) with driver bound to > this VF? > > Thanks! > > Paolo > > . >